You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2019/07/08 13:11:00 UTC
[jira] [Comment Edited] (OAK-7547) commons: avoid use of Guava beta
APIs in StringSort
[ https://issues.apache.org/jira/browse/OAK-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797099#comment-16797099 ]
Julian Reschke edited comment on OAK-7547 at 7/8/19 1:10 PM:
-------------------------------------------------------------
trunk: (1.9.4) [r1833702|http://svn.apache.org/r1833702]
1.8: (1.8.13) [r1855897|http://svn.apache.org/r1855897]
1.6: [r1862744|http://svn.apache.org/r1862744]
was (Author: reschke):
trunk: [r1833702|http://svn.apache.org/r1833702]
1.8: [r1855897|http://svn.apache.org/r1855897]
> commons: avoid use of Guava beta APIs in StringSort
> ---------------------------------------------------
>
> Key: OAK-7547
> URL: https://issues.apache.org/jira/browse/OAK-7547
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: commons
> Reporter: Julian Reschke
> Priority: Major
> Labels: candidate_oak_1_4
> Fix For: 1.10.0, 1.9.4, 1.8.13, 1.6.18
>
> Attachments: OAK-7547.diff
>
>
> Output from compile with {{-Pguavabetachecks}}:
> {noformat}
> [INFO] Compiling 33 source files to /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/target/classes
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:187: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> writer = Files.newWriter(idFile, charset);
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:187: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> writer = Files.newWriter(idFile, charset);
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:213: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> CloseableIterator itr = new CloseableIterator(Files.newReader(sortedFile, charset));
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:213: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> CloseableIterator itr = new CloseableIterator(Files.newReader(sortedFile, charset));
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:225: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> Closer closer = Closer.create();
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:225: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> Closer closer = Closer.create();
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:225: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> Closer closer = Closer.create();
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:228: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> closer.register(new Closeable() {
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:234: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> closer.register(writer);
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:236: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> closer.register(citr);
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> /home/jenkins/jenkins-slave/workspace/Apache Jackrabbit Oak matrix/Ubuntu Slaves/ubuntu/jdk/JDK 1.8 (latest)/nsfixtures/SEGMENT_TAR/profile/guavabetachecks/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/StringSort.java:239: error: [BetaApi] @Beta APIs should not be used in library code as they are subject to change
> closer.close();
> ^
> (see https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis)
> 11 errors
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)