You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/22 04:23:14 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #24420:
[SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in
microsecond precision
cloud-fan commented on a change in pull request #24420: [SPARK-27438][SQL] Parse strings with timestamps by to_timestamp() in microsecond precision
URL: https://github.com/apache/spark/pull/24420#discussion_r277203255
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -626,9 +626,11 @@ case class UnixTimestamp(timeExp: Expression, format: Expression, timeZoneId: Op
override def prettyName: String = "unix_timestamp"
}
-abstract class UnixTime
+abstract class ToTimestamp
extends BinaryExpression with TimeZoneAwareExpression with ExpectsInputTypes {
+ protected def downScaleFactor: Long
Review comment:
let's add a comment about what `downScaleFactor` means.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org