[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4193: Creation/deletion flow for replica groups sets in realtime

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4193: Creation/deletion flow for replica groups sets in realtime
URL: https://github.com/apache/incubator-pinot/pull/4193#discussion_r282195300
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -1112,6 +1112,9 @@ public void addTable(@Nonnull TableConfig tableConfig)
         // lets add table configs
         ZKMetadataProvider.setRealtimeTableConfig(_propertyStore, tableNameWithType, tableConfig.toZNRecord());
 
+        // Update replica group partition assignment to the property store if applicable
+        updateReplicaGroupPartitionAssignment(tableConfig);
 
 Review comment:
   only if LLC? Also need to make sure in the table config update case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org