You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Aaron Kimball (JIRA)" <ji...@apache.org> on 2009/06/04 03:06:07 UTC

[jira] Created: (HADOOP-5968) Sqoop should only print a warning about mysql import speed once

Sqoop should only print a warning about mysql import speed once
---------------------------------------------------------------

                 Key: HADOOP-5968
                 URL: https://issues.apache.org/jira/browse/HADOOP-5968
             Project: Hadoop Core
          Issue Type: Improvement
            Reporter: Aaron Kimball
            Assignee: Aaron Kimball
            Priority: Minor
         Attachments: mysql-warning.patch

After HADOOP-5844, Sqoop can use mysqldump as an alternative to JDBC for importing from MySQL. If you use the JDBC mechanism, it prints a warning if you could have enabled the mysqldump path instead. But the warning is printed multiple times (every time the LocalMySQLManager is instantiated), and also when the MySQL manager is used for informational queries (e.g., listing tables) rather than true imports.

It should only emit the warning once per session, and only then if it's actually doing an import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5968) Sqoop should only print a warning about mysql import speed once

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717331#action_12717331 ] 

Aaron Kimball commented on HADOOP-5968:
---------------------------------------

Hudson's test failures are unrelated

> Sqoop should only print a warning about mysql import speed once
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5968
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5968
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: mysql-warning.patch
>
>
> After HADOOP-5844, Sqoop can use mysqldump as an alternative to JDBC for importing from MySQL. If you use the JDBC mechanism, it prints a warning if you could have enabled the mysqldump path instead. But the warning is printed multiple times (every time the LocalMySQLManager is instantiated), and also when the MySQL manager is used for informational queries (e.g., listing tables) rather than true imports.
> It should only emit the warning once per session, and only then if it's actually doing an import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5968) Sqoop should only print a warning about mysql import speed once

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated HADOOP-5968:
----------------------------------

    Attachment: mysql-warning.patch

Attaching patch for this message. No test because it just moves log4j messages around -- does not affect functionality.

> Sqoop should only print a warning about mysql import speed once
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5968
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5968
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: mysql-warning.patch
>
>
> After HADOOP-5844, Sqoop can use mysqldump as an alternative to JDBC for importing from MySQL. If you use the JDBC mechanism, it prints a warning if you could have enabled the mysqldump path instead. But the warning is printed multiple times (every time the LocalMySQLManager is instantiated), and also when the MySQL manager is used for informational queries (e.g., listing tables) rather than true imports.
> It should only emit the warning once per session, and only then if it's actually doing an import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5968) Sqoop should only print a warning about mysql import speed once

Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Kimball updated HADOOP-5968:
----------------------------------

    Status: Patch Available  (was: Open)

> Sqoop should only print a warning about mysql import speed once
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5968
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5968
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: mysql-warning.patch
>
>
> After HADOOP-5844, Sqoop can use mysqldump as an alternative to JDBC for importing from MySQL. If you use the JDBC mechanism, it prints a warning if you could have enabled the mysqldump path instead. But the warning is printed multiple times (every time the LocalMySQLManager is instantiated), and also when the MySQL manager is used for informational queries (e.g., listing tables) rather than true imports.
> It should only emit the warning once per session, and only then if it's actually doing an import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5968) Sqoop should only print a warning about mysql import speed once

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-5968:
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

+1

I've just committed this. Thanks Aaron!

> Sqoop should only print a warning about mysql import speed once
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5968
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5968
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: mysql-warning.patch
>
>
> After HADOOP-5844, Sqoop can use mysqldump as an alternative to JDBC for importing from MySQL. If you use the JDBC mechanism, it prints a warning if you could have enabled the mysqldump path instead. But the warning is printed multiple times (every time the LocalMySQLManager is instantiated), and also when the MySQL manager is used for informational queries (e.g., listing tables) rather than true imports.
> It should only emit the warning once per session, and only then if it's actually doing an import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5968) Sqoop should only print a warning about mysql import speed once

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716884#action_12716884 ] 

Hadoop QA commented on HADOOP-5968:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12409838/mysql-warning.patch
  against trunk revision 782083.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/473/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/473/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/473/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/473/console

This message is automatically generated.

> Sqoop should only print a warning about mysql import speed once
> ---------------------------------------------------------------
>
>                 Key: HADOOP-5968
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5968
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: mysql-warning.patch
>
>
> After HADOOP-5844, Sqoop can use mysqldump as an alternative to JDBC for importing from MySQL. If you use the JDBC mechanism, it prints a warning if you could have enabled the mysqldump path instead. But the warning is printed multiple times (every time the LocalMySQLManager is instantiated), and also when the MySQL manager is used for informational queries (e.g., listing tables) rather than true imports.
> It should only emit the warning once per session, and only then if it's actually doing an import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.