You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/18 15:22:05 UTC
[GitHub] [superset] alec-heif opened a new issue, #20115: Superset should include catalog in the request to Trino's `system.metadata.table_comments` table
alec-heif opened a new issue, #20115:
URL: https://github.com/apache/superset/issues/20115
See issue title
#### How to reproduce the bug
1. Add a Trino Database that has a specific catalog with connection string `trino://{username}:{password}@{hostname}:{port}/{catalog}`
2. Attempt to add a Dataset with a schema and table name that exist in `catalog`. Let's say `my_schema` and `my_table`
3. Look at the queries made to Trino.
### Expected results
Superset should make a query like
```
SELECT "comment"
FROM "system"."metadata"."table_comments"
WHERE "schema_name" = 'default'
AND "table_name" = 'accounts'
AND "catalog_name" = 'my_catalog'
```
### Actual results
Superset makes a query like
```
SELECT "comment"
FROM "system"."metadata"."table_comments"
WHERE "schema_name" = 'default'
AND "table_name" = 'accounts'
```
which will erroneously include results for ALL catalogs that have a matching schema and table name.
### Environment
- superset version: latest
### Checklist
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dungdm93 commented on issue #20115: Superset should include catalog in the request to Trino's `system.metadata.table_comments` table
Posted by GitBox <gi...@apache.org>.
dungdm93 commented on issue #20115:
URL: https://github.com/apache/superset/issues/20115#issuecomment-1212719580
See trinodb/trino-python-client#218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset should include catalog in the request to Trino's `system.metadata.table_comments` table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20115:
URL: https://github.com/apache/superset/issues/20115#issuecomment-1939802269
Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please open a new Issue or a PR to address the problem.
CC @bkyryliuk @nytai @villebro in case any of you feel differently and want to repro/reopen this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Superset should include catalog in the request to Trino's `system.metadata.table_comments` table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #20115: Superset should include catalog in the request to Trino's `system.metadata.table_comments` table
URL: https://github.com/apache/superset/issues/20115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EMCP commented on issue #20115: Superset should include catalog in the request to Trino's `system.metadata.table_comments` table
Posted by GitBox <gi...@apache.org>.
EMCP commented on issue #20115:
URL: https://github.com/apache/superset/issues/20115#issuecomment-1272335216
is this bug the reason for the behavior noted in https://github.com/apache/superset/issues/21745 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #20115: Superset should include catalog in the request to Trino's `system.metadata.table_comments` table
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #20115:
URL: https://github.com/apache/superset/issues/20115#issuecomment-1137411515
@john-bodley do you know of anyone who would be a good fit to take a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org