[jira] Commented: (THRIFT-803) Twisted servers close the connection with no error response when an unhandled error occurs

["Esteve Fernandez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889278#action_12889278 ] 

Esteve Fernandez commented on THRIFT-803:
-----------------------------------------

I'm not against adding a log.err call and do more error handling,  I added a processError method in the server protocol for this reason, actually we have our own modified protocol that does log errors. However the problem is that it has to be implemented across all languages and I thought Thrift shouldn't force you to use log.err (or anything else), but let you define the way you want to handle errors. For example, you might want to use Scribe or any other logging mechanism to log failures.

> Twisted servers close the connection with no error response when an unhandled error occurs
> ------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-803
>                 URL: https://issues.apache.org/jira/browse/THRIFT-803
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>    Affects Versions: 0.2
>         Environment: Debian, Ubuntu
>            Reporter: Christopher Armstrong
>
> When an unhandled error occurs in a service handler, the connection is closed but no message is sent to the client to indicate that an error occurred.
> Mattias de Zalenski first mentioned this issue in a comment:
> https://issues.apache.org/jira/browse/THRIFT-585?focusedCommentId=12757052&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12757052
> And he attached a fix for it, though in an undesirable format (changing the compiler instead of the library, and as an entire .cc file instead of a patch):
> https://issues.apache.org/jira/secure/attachment/12419992/t_py_generator.cc
> IMO, in addition to sending back an error message to the client, unhandled errors should also be logged with log.err().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.