You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/02/23 16:10:07 UTC

[GitHub] flink pull request: [FLINK-3434] Prevent NPE in ClieFrotend#getCli...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1695

    [FLINK-3434] Prevent NPE in ClieFrotend#getClient()

    CliFrontend#getClient() can enocunter a NullPointerException when executing 
    ```
    yarnCluster = flinkYarnClient.deploy();
    yarnCluster.connectToCluster();
    ```
    since the deploy call can return null if ```org.apache.flink.core.fs.FileSystem.setDefaultScheme(flinkConfiguration)``` 
    throws an IOException . 
    
    This NPE would be catched and wrapped in a new IOException. By rethrowing the original IOException directly instead of returning null the whole affair is a bit more straight forward, and removes an unnecessary exception form the stack trace.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 3434_yarn_deploy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1695
    
----
commit 3b2e36ae466f7f8c6afc3dfd0fd85a519f04a83a
Author: zentol <s....@web.de>
Date:   2016-02-18T12:35:39Z

    [FLINK-3434] Prevent NPE in ClieFrotend#getClient()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3434] Prevent NPE in ClientFrontend#get...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1695#issuecomment-187748356
  
    +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3434] Prevent NPE in ClientFrontend#get...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1695


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3434] Prevent NPE in ClientFrontend#get...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1695#issuecomment-189210454
  
    Merging ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---