You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/09/14 22:58:40 UTC

[Impala-ASF-CR] IMPALA-7576: Add a timeout for all E2E tests

Thomas Marshall has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11447 )

Change subject: IMPALA-7576: Add a timeout for all E2E tests
......................................................................

IMPALA-7576: Add a timeout for all E2E tests

We've been seeing a lot of hangs in tests lately. This can waste
test resources by keeping machines busy, cause loss of coverage when
subsequent tests don't run, and can be difficult to diagnose if its
not clear which test hung.

This patch introduces a timeout of 2 hours for normal builds and 4
hours for slow builds for all tests run under pytest by using the
pytest-timeout plugin.

The timeouts were chosen to be generous to avoid false positives.
In recent runs I examined, the longest running test is
test_decimal_fuzz, which took 63 minutes in a DEBUG build and
162 minutes in an ASAN build.

Testing:
- Ran locally with a reduced timeout and confirmed the test is
  timed out when expected.

Change-Id: I301dd27a9767bfaef2756282014ef457a31956bd
---
M infra/python/deps/stage2-requirements.txt
M tests/run-tests.py
2 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/11447/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I301dd27a9767bfaef2756282014ef457a31956bd
Gerrit-Change-Number: 11447
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>