You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2007/08/17 01:09:30 UTC
[jira] Commented: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation changed between 1.2.5
and 1.2.6
[ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520404 ]
Martijn Dashorst commented on WICKET-511:
-----------------------------------------
So, we are not going to re-/un-/de-/fix this? The damage has been done, no point in reverting a released api break imo. We should just document this and call it a day.
> New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
> --------------------------------------------------------------------------------------
>
> Key: WICKET-511
> URL: https://issues.apache.org/jira/browse/WICKET-511
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.6
> Reporter: Jan Bareš
> Priority: Trivial
> Fix For: 1.2.7
>
>
> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> return new HashMap(httpServletRequest.getParameterMap());
> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (WICKET-511) New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
Posted by Martijn Dashorst <ma...@gmail.com>.
I closed the issue as won't fix.
Martijn
--
Wicket joins the Apache Software Foundation as Apache Wicket
Apache Wicket 1.3.0-beta2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta2/
Re: [jira] Commented: (WICKET-511) New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
Posted by Eelco Hillenius <ee...@gmail.com>.
On 8/17/07, Martijn Dashorst <ma...@gmail.com> wrote:
> The future (> 1.3) relies on this functionality, and I guess an
> upgrade from 1.2.3 -> 1.2.7 is not going to be a drop-in replacement
> of a jar (was on the user list a month ago).
>
> I think that we should keep it. 1.2.6 is the currently most downloaded
> release ever. Reverting the change would mean changing it twice for
> upgraders to 1.3 which seems silly.
>
> It is unfortunate that this happened, and we should do a mea culpa,
> document it, and fix the other 2 issues left for 1.2.7 and release it.
+1
Eelco
Re: [jira] Commented: (WICKET-511) New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
Posted by Martijn Dashorst <ma...@gmail.com>.
The future (> 1.3) relies on this functionality, and I guess an
upgrade from 1.2.3 -> 1.2.7 is not going to be a drop-in replacement
of a jar (was on the user list a month ago).
I think that we should keep it. 1.2.6 is the currently most downloaded
release ever. Reverting the change would mean changing it twice for
upgraders to 1.3 which seems silly.
It is unfortunate that this happened, and we should do a mea culpa,
document it, and fix the other 2 issues left for 1.2.7 and release it.
Martijn
On 8/17/07, Al Maw <wi...@almaw.com> wrote:
> Hmm. IMO we should revert it as a regression bug. That way people
> updating from 1.2.3 etc won't be bitten.
>
> OTOH, I guess there may be lots of people who now rely on the different
> functionality with their 1.2.6 projects (the 1.2.6 release has been out
> for a while after all).
>
> I'm thus fairly ambivalent either way on this.
>
> Al
>
> Martijn Dashorst wrote:
> > Shall we close this issue and just document it as an unfortunate API
> > break for 1.2.7 and later 1.2.x releases?
> >
> > Martijn
> >
> > On 8/17/07, Martijn Dashorst (JIRA) <ji...@apache.org> wrote:
> >> [ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520404 ]
> >>
> >> Martijn Dashorst commented on WICKET-511:
> >> -----------------------------------------
> >>
> >> So, we are not going to re-/un-/de-/fix this? The damage has been done, no point in reverting a released api break imo. We should just document this and call it a day.
> >>
> >>> New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
> >>> --------------------------------------------------------------------------------------
> >>>
> >>> Key: WICKET-511
> >>> URL: https://issues.apache.org/jira/browse/WICKET-511
> >>> Project: Wicket
> >>> Issue Type: Bug
> >>> Components: wicket
> >>> Affects Versions: 1.2.6
> >>> Reporter: Jan Bareš
> >>> Priority: Trivial
> >>> Fix For: 1.2.7
> >>>
> >>>
> >>> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> >>> return new HashMap(httpServletRequest.getParameterMap());
> >>> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >>
> >
> >
>
>
> --
> Alastair Maw
> Wicket-biased blog at http://herebebeasties.com
>
--
Wicket joins the Apache Software Foundation as Apache Wicket
Apache Wicket 1.3.0-beta2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta2/
Re: [jira] Commented: (WICKET-511) New ServletWebRequest.getParameterMap()
implementation changed between 1.2.5 and 1.2.6
Posted by Al Maw <wi...@almaw.com>.
Hmm. IMO we should revert it as a regression bug. That way people
updating from 1.2.3 etc won't be bitten.
OTOH, I guess there may be lots of people who now rely on the different
functionality with their 1.2.6 projects (the 1.2.6 release has been out
for a while after all).
I'm thus fairly ambivalent either way on this.
Al
Martijn Dashorst wrote:
> Shall we close this issue and just document it as an unfortunate API
> break for 1.2.7 and later 1.2.x releases?
>
> Martijn
>
> On 8/17/07, Martijn Dashorst (JIRA) <ji...@apache.org> wrote:
>> [ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520404 ]
>>
>> Martijn Dashorst commented on WICKET-511:
>> -----------------------------------------
>>
>> So, we are not going to re-/un-/de-/fix this? The damage has been done, no point in reverting a released api break imo. We should just document this and call it a day.
>>
>>> New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
>>> --------------------------------------------------------------------------------------
>>>
>>> Key: WICKET-511
>>> URL: https://issues.apache.org/jira/browse/WICKET-511
>>> Project: Wicket
>>> Issue Type: Bug
>>> Components: wicket
>>> Affects Versions: 1.2.6
>>> Reporter: Jan Bareš
>>> Priority: Trivial
>>> Fix For: 1.2.7
>>>
>>>
>>> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
>>> return new HashMap(httpServletRequest.getParameterMap());
>>> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
--
Alastair Maw
Wicket-biased blog at http://herebebeasties.com
Re: [jira] Commented: (WICKET-511) New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
Posted by Martijn Dashorst <ma...@gmail.com>.
Shall we close this issue and just document it as an unfortunate API
break for 1.2.7 and later 1.2.x releases?
Martijn
On 8/17/07, Martijn Dashorst (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520404 ]
>
> Martijn Dashorst commented on WICKET-511:
> -----------------------------------------
>
> So, we are not going to re-/un-/de-/fix this? The damage has been done, no point in reverting a released api break imo. We should just document this and call it a day.
>
> > New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
> > --------------------------------------------------------------------------------------
> >
> > Key: WICKET-511
> > URL: https://issues.apache.org/jira/browse/WICKET-511
> > Project: Wicket
> > Issue Type: Bug
> > Components: wicket
> > Affects Versions: 1.2.6
> > Reporter: Jan Bareš
> > Priority: Trivial
> > Fix For: 1.2.7
> >
> >
> > The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> > return new HashMap(httpServletRequest.getParameterMap());
> > According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Wicket joins the Apache Software Foundation as Apache Wicket
Apache Wicket 1.3.0-beta2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta2/