You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2018/04/20 13:31:19 UTC
[GitHub] nifi-minifi-cpp pull request #304: Providing fixes for sourcing RHEL based d...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/304
Providing fixes for sourcing RHEL based distributions in the bootstrap process
Providing fixes for sourcing RHEL based distributions in the bootstrap process
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi-cpp MINIFICPP-461
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit ddcf826c3493cc41e66e1b8564a0d927a72ccda9
Author: Aldrin Piri <al...@...>
Date: 2018-04-20T12:48:48Z
Providing fixes for sourcing RHEL based distributions in the bootstrap process
----
---
[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/304
@apiri what was the problem you were experiencing and on what distro specifically? I don't see an issue on the clean rhel distros I have running now,
---
[GitHub] nifi-minifi-cpp pull request #304: Providing fixes for sourcing RHEL based d...
Posted by apiri <gi...@git.apache.org>.
GitHub user apiri reopened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/304
Providing fixes for sourcing RHEL based distributions in the bootstrap process
Providing fixes for sourcing RHEL based distributions in the bootstrap process
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi-cpp MINIFICPP-461
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit 0a792843218e14fa9476072b4b1dd9d3ee81df2a
Author: Aldrin Piri <al...@...>
Date: 2018-04-20T13:34:12Z
MINIFICPP-461 Providing fixes for sourcing env files in RHEL based distributions during bootstrap process
----
---
[GitHub] nifi-minifi-cpp pull request #304: Providing fixes for sourcing RHEL based d...
Posted by apiri <gi...@git.apache.org>.
Github user apiri closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/304
---
[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/304
Updated the script to determine the directory in which it resides and then uses that to generate a full path for each environment file sourced. Verification on OS X looks like behavior remains constant and this additionally resolves the issues that were present in CentOS & Fedora.
---
[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/304
@apiri looks good. will merge.
---
[GitHub] nifi-minifi-cpp pull request #304: Providing fixes for sourcing RHEL based d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/304
---
[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/304
These changes look good at face value. I'm going to try it across a few platforms and await travis completion before merging. Thanks!
---