[jira] [Commented] (ZOOKEEPER-1206) Sequential node creation does not use always use digits in node name given certain Locales.

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117109#comment-13117109 ] 

Hadoop QA commented on ZOOKEEPER-1206:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12496964/ZOOKEEPER-1206.patch
  against trunk revision 1177191.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/596//console

This message is automatically generated.
                
> Sequential node creation does not use always use digits in node name given certain Locales.
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1206
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1206
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 3.3.4, 3.4.0, 3.5.0
>
>         Attachments: ZOOKEEPER-1206-3.4.patch, ZOOKEEPER-1206.patch
>
>
> While I always expect to be able to parse a sequential node by looking for digits, under some locals you end up with non digits - for example: n_००००००००००
> It looks like the problem is around line 236 in PrepRequestProcessor:
> {code}
>                 if (createMode.isSequential()) {
>                     path = path + String.format("%010d", parentCVersion);
>                 }
> {code}
> Instead we should pass Locale.ENGLISH to the format call.
> {code}
>                 if (createMode.isSequential()) {
>                     path = path + String.format(Locale.ENGLISH, "%010d", parentCVersion);
>                 }
> {code}
> Lucene/Solr tests with random Locales, and some of my tests that try and inspect the node name and order things expect to find digits - currently my leader election recipe randomly fails when the wrong locale pops up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira