You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/14 12:37:06 UTC

[GitHub] [incubator-seatunnel] ruanwenjun opened a new pull request #1484: [Improvement][Config] Print config in origin order

ruanwenjun opened a new pull request #1484:
URL: https://github.com/apache/incubator-seatunnel/pull/1484


   ## Purpose of this pull request
   close #1473 
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1484: [Improvement][Config] Print config in origin order

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1484:
URL: https://github.com/apache/incubator-seatunnel/pull/1484#issuecomment-1068085230


   > I find many code improve in this PR, It's great to do code improve, If not much we can just use one PR . If code improve change too much, I suggest split it into two PR next time. It's good for code review and PR check. Thanks
   
   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1484: [Improvement][Config] Print config in origin order

Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1484:
URL: https://github.com/apache/incubator-seatunnel/pull/1484#issuecomment-1068083226


   @CalvinKirs LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1484: [Improvement][Config] Print config in origin order

Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1484:
URL: https://github.com/apache/incubator-seatunnel/pull/1484#issuecomment-1068082541


   I find many code improve in this PR, It's great to do code improve, If not much we can just use one PR . If code improve change too much, I suggest split it into two PR next time. It's good for code review and PR check. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1484: [Improvement][Config] Print config in origin order

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1484:
URL: https://github.com/apache/incubator-seatunnel/pull/1484


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1484: [Improvement][Config] Print config in origin order

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #1484:
URL: https://github.com/apache/incubator-seatunnel/pull/1484#issuecomment-1067693410


   > you need to add reference to this :
   > 
   > https://github.com/apache/incubator-seatunnel/blob/159eb8423c99f21f951abe1a37753bafa206c4dc/LICENSE#L216
   
   Thanks for your reminder, I added this announces, please help to take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org