You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/29 05:12:20 UTC
[PR] test(pyamber): extend IO, packaging and storage-model coverage [texera]
aglinxinyuan opened a new pull request, #7019:
URL: https://github.com/apache/texera/pull/7019
### What changes were proposed in this PR?
Extends three pyamber suites and adds two new test files. No source changes.
- **`core/storage/runnables/input_port_materialization_reader_runnable.py`** (~83% covered): extended over the uncovered branches.
- **`core/architecture/packaging/input_manager.py`** (~88% covered, **no dedicated test**): new test file.
- **`core/models/tuple.py`** (~95% covered) and **`pytexera/udf/udf_operator.py`** (~94% covered): extended.
- **`core/storage/model/virtual_document.py`** (~74% covered, **no dedicated test**): new test file.
Tests are hermetic and deterministic — no real sleeps, nothing left running.
### Any related issues, documentation, discussions?
Closes #7017.
### How was this PR tested?
`python -m pytest` over the five files -> 187 passed. (`TestTuple::test_hash` is deselected locally: it fails identically on unmodified `main` under Windows because `tuple.py` calls `datetime.timestamp()`, which raises `OSError [Errno 22]` there; it passes on the Linux CI runners.) `ruff format --check` + `ruff check` clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): extend IO, packaging and storage-model coverage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7019:
URL: https://github.com/apache/texera/pull/7019#issuecomment-5113552726
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 6 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `ab58d47` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30424401101)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 371 | 0.227 | 25,652/35,116/35,116 us | 🔴 +21.0% / 🔴 +122.2% |
| 🔴 | bs=100 sw=10 sl=64 | 783 | 0.478 | 127,059/159,936/159,936 us | 🔴 +8.2% / 🔴 +49.0% |
| ⚪ | bs=1000 sw=10 sl=64 | 907 | 0.554 | 1,097,395/1,147,577/1,147,577 us | ⚪ within ±5% / 🔴 -12.0% |
<details><summary>Baseline details</summary>
Latest main `ab58d47` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 371 tuples/sec | 432 tuples/sec | 787.55 tuples/sec | -14.1% | -52.9% |
| bs=10 sw=10 sl=64 | MB/s | 0.227 MB/s | 0.264 MB/s | 0.481 MB/s | -14.0% | -52.8% |
| bs=10 sw=10 sl=64 | p50 | 25,652 us | 21,202 us | 12,255 us | +21.0% | +109.3% |
| bs=10 sw=10 sl=64 | p95 | 35,116 us | 36,156 us | 15,802 us | -2.9% | +122.2% |
| bs=10 sw=10 sl=64 | p99 | 35,116 us | 36,156 us | 19,008 us | -2.9% | +84.7% |
| bs=100 sw=10 sl=64 | throughput | 783 tuples/sec | 812 tuples/sec | 997.81 tuples/sec | -3.6% | -21.5% |
| bs=100 sw=10 sl=64 | MB/s | 0.478 MB/s | 0.496 MB/s | 0.609 MB/s | -3.6% | -21.5% |
| bs=100 sw=10 sl=64 | p50 | 127,059 us | 120,317 us | 100,690 us | +5.6% | +26.2% |
| bs=100 sw=10 sl=64 | p95 | 159,936 us | 147,857 us | 107,316 us | +8.2% | +49.0% |
| bs=100 sw=10 sl=64 | p99 | 159,936 us | 147,857 us | 113,823 us | +8.2% | +40.5% |
| bs=1000 sw=10 sl=64 | throughput | 907 tuples/sec | 901 tuples/sec | 1,030 tuples/sec | +0.7% | -12.0% |
| bs=1000 sw=10 sl=64 | MB/s | 0.554 MB/s | 0.55 MB/s | 0.629 MB/s | +0.7% | -11.9% |
| bs=1000 sw=10 sl=64 | p50 | 1,097,395 us | 1,111,775 us | 981,213 us | -1.3% | +11.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,147,577 us | 1,136,662 us | 1,027,605 us | +1.0% | +11.7% |
| bs=1000 sw=10 sl=64 | p99 | 1,147,577 us | 1,136,662 us | 1,055,466 us | +1.0% | +8.7% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,538.58,200,128000,371,0.227,25652.49,35116.10,35116.10
1,100,10,64,20,2553.95,2000,1280000,783,0.478,127058.81,159935.50,159935.50
2,1000,10,64,20,22051.35,20000,12800000,907,0.554,1097395.23,1147576.67,1147576.67
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): extend IO, packaging and storage-model coverage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7019:
URL: https://github.com/apache/texera/pull/7019#issuecomment-5113514566
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@eugenegujing`, `@carloea2`
You can notify them by mentioning `@eugenegujing`, `@carloea2` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): extend IO, packaging and storage-model coverage [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7019:
URL: https://github.com/apache/texera/pull/7019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): extend IO, packaging and storage-model coverage [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7019:
URL: https://github.com/apache/texera/pull/7019#issuecomment-5113611124
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7019?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.18%. Comparing base ([`469e8f0`](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1bcc3f8`](https://app.codecov.io/gh/apache/texera/commit/1bcc3f8da8f7ce6104f6f05dce3e6213551d4f97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7019 +/- ##
============================================
+ Coverage 78.99% 79.18% +0.19%
Complexity 3788 3788
============================================
Files 1160 1160
Lines 46105 46105
Branches 5115 5115
============================================
+ Hits 36419 36509 +90
+ Misses 8067 7977 -90
Partials 1619 1619
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.20% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.99% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.38% <ø> (+1.99%)` | :arrow_up: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [469e8f0](https://app.codecov.io/gh/apache/texera/commit/469e8f031c9b95282ff2cab1388f6c95f4a0045d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7019?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org