[GitHub] rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.

[GitBox <gi...@apache.org>]

rcorre commented on issue #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.
URL: https://github.com/apache/incubator-airflow/pull/3546#issuecomment-443736807
 
 
   Still having some trouble with the test:
   
   ```
   ======================================================================
   47) FAIL: test_get_dag_runs_success_with_run_id__like_parameter (tests.www_rbac.api.experimental.test_dag_runs_endpoint.TestDagRunsEndpoint)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       tests/www_rbac/api/experimental/test_dag_runs_endpoint.py line 90 in test_get_dag_runs_success_with_run_id__like_parameter
         execution_date=datetime.datetime.fromtimestamp(1539097214),
       airflow/api/common/experimental/trigger_dag.py line 104 in trigger_dag
         replace_microseconds=replace_microseconds,
       airflow/api/common/experimental/trigger_dag.py line 45 in _trigger_dag
         assert timezone.is_localized(execution_date)
      AssertionError: 
   ```
   
   My next guess is to just remove the `execution_date` parameter, but it seems like a bad idea to have unit tests with a field that can change every time you execute them.
   
   I haven't been able to test at all locally. After following the steps in `CONTRIBUTING.md`:
   
   ```
   docker run -t -i -v `pwd`:/airflow/ -w /airflow/ -e SLUGIFY_USES_TEXT_UNIDECODE=yes python:3.5 bash
   cd /airflow/
   pip install -e ".[hdfs,hive,druid,devel]"
   airflow initdb
   nosetests -v tests/www_rbac/api/experimental/test_dag_runs_endpoint.py
   ```
   
   Every test fails with:
   
   ```
   ======================================================================
   ERROR: test_get_dag_runs_success (tests.www_rbac.api.experimental.test_dag_runs_endpoint.TestDagRunsEndpoint)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/airflow/tests/www_rbac/api/experimental/test_dag_runs_endpoint.py", line 43, in setUp
       app, _ = application.create_app(testing=True)
     File "/airflow/airflow/www_rbac/app.py", line 146, in create_app
       security_manager.sync_roles()
     File "/airflow/airflow/www_rbac/security.py", line 439, in sync_roles
       self.create_custom_dag_permission_view()
     File "/airflow/airflow/www_rbac/security.py", line 387, in create_custom_dag_permission_view
       all_perm_views = set([role.permission_view_id for role in all_perm_view_by_user])
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/orm/query.py", line 2855, in __iter__
       return self._execute_and_instances(context)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/orm/query.py", line 2878, in _execute_and_instances
       result = conn.execute(querycontext.statement, self._params)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 945, in execute
       return meth(self, multiparams, params)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/sql/elements.py", line 263, in _execute_on_connection
       return connection._execute_clauseelement(self, multiparams, params)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1053, in _execute_clauseelement
       compiled_sql, distilled_params
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1189, in _execute_context
       context)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1402, in _handle_dbapi_exception
       exc_info
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
       reraise(type(exception), exception, tb=exc_tb, cause=cause)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/util/compat.py", line 186, in reraise
       raise value.with_traceback(tb)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1182, in _execute_context
       context)
     File "/usr/local/lib/python3.5/site-packages/sqlalchemy/engine/default.py", line 470, in do_execute
       cursor.execute(statement, parameters)
   sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: ab_permission_view_role [SQL: 'SELECT ab_permission_view_role.id AS ab_permission_view_role_id, ab_permission_view_role.permission_view_id AS ab_permission_view_role_permission_view_id, ab_permission_view_role.role_id AS ab_permission_view_role_role_id \nFROM ab_permission_view_role JOIN ab_permission_view ON ab_permission_view.id = ab_permission_view_role.permission_view_id JOIN ab_view_menu ON ab_view_menu.id = ab_permission_view.view_menu_id \nWHERE ab_permission_view_role.role_id = ? AND ab_permission_view.view_menu_id != ?'] [parameters: (4, 51)]
   ```
   
   Any ideas?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services