[GitHub] [doris] nextdreamblue commented on pull request #14722: [fix](vec) VMergeIterator add key same label for agg table

[GitBox <gi...@apache.org>]

nextdreamblue commented on PR #14722:
URL: https://github.com/apache/doris/pull/14722#issuecomment-1352895192

   > Can't we just compare 2 rows in `_agg_key_next_block` to check if they are same? Just like what the rowwise implementation did.
   
   like in 
   `_agg_key_next_row` ,
   ```
    if (!equal_row(_key_cids, *row_cursor, *_next_key)) {
       break;
   }
   ```
   总感觉这样整个查询效率会低好多，多一次重复比较。我试试用roaringbitmap代替vector吧


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org