You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gilles Sadowski <gi...@gmail.com> on 2019/04/10 12:02:39 UTC
[RNG] Re: [commons-rng] 02/02: Disable redundant JMH benchmarks and
mark as deprecated.
Hello Alex.
> [...]
>
> commit 431a51b8211a40e5e8d9df0406563d4873eb4eb6
> Author: aherbert <ah...@apache.org>
> AuthorDate: Wed Apr 10 11:01:05 2019 +0100
>
> Disable redundant JMH benchmarks and mark as deprecated.
Is there and advantage to keeping disabled code?
[Usually, it rots silently until nobody knows why it was there... ]
If you are sure that no functionality is lost, and that the replacement
is better; I'd favour removing it. Code archaelogists can always turn
to the VCS, if need be.
Regards,
Gilles
> ---
> .../rng/examples/jmh/GenerationPerformance.java | 21 ++++++++------
> .../jmh/distribution/SamplersPerformance.java | 33 ++++++++++++----------
> 2 files changed, 30 insertions(+), 24 deletions(-)
>
> diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java
> index 6b4e993..741c510 100644
> --- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java
> +++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java
> @@ -17,7 +17,6 @@
>
> [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [RNG] Re: [commons-rng] 02/02: Disable redundant JMH benchmarks
and mark as deprecated.
Posted by Alex Herbert <al...@gmail.com>.
On 10/04/2019 13:02, Gilles Sadowski wrote:
> Hello Alex.
>
>> [...]
>>
>> commit 431a51b8211a40e5e8d9df0406563d4873eb4eb6
>> Author: aherbert <ah...@apache.org>
>> AuthorDate: Wed Apr 10 11:01:05 2019 +0100
>>
>> Disable redundant JMH benchmarks and mark as deprecated.
> Is there and advantage to keeping disabled code?
> [Usually, it rots silently until nobody knows why it was there... ]
>
> If you are sure that no functionality is lost, and that the replacement
> is better; I'd favour removing it. Code archaelogists can always turn
> to the VCS, if need be.
I was going to run all the benchmarks tonight just to check them. Then I
can remove the old ones.
Alex
>
> Regards,
> Gilles
>
>> ---
>> .../rng/examples/jmh/GenerationPerformance.java | 21 ++++++++------
>> .../jmh/distribution/SamplersPerformance.java | 33 ++++++++++++----------
>> 2 files changed, 30 insertions(+), 24 deletions(-)
>>
>> diff --git a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java
>> index 6b4e993..741c510 100644
>> --- a/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java
>> +++ b/commons-rng-examples/examples-jmh/src/main/java/org/apache/commons/rng/examples/jmh/GenerationPerformance.java
>> @@ -17,7 +17,6 @@
>>
>> [...]
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org