You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/31 03:02:45 UTC
[GitHub] [flink] xiaoHoly opened a new pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interva…
xiaoHoly opened a new pull request #14531:
URL: https://github.com/apache/flink/pull/14531
…l.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
## Brief change log
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r587183656
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -423,14 +430,15 @@ private void parseAndSetRequiredProperties() {
startingOffsetsInitializer.getAutoOffsetResetStrategy().name().toLowerCase(),
true);
- // If the source is bounded, do not run periodic partition discovery.
- if (maybeOverride(
- KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS.key(),
- "-1",
- boundedness == Boundedness.BOUNDED)) {
- LOG.warn(
- "{} property is overridden to -1 because the source is bounded.",
- KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS);
+ // If the source is bounded or stoppingOffsetsInitializer is specified, do not run periodic
Review comment:
Should we update the comments here as well? It probably should be something like:
"We only disable the periodic partition discovery in the following cases:
1. The source is bounded.
2. The source has stopping offsets and there is no explicit partition discovery interval setting."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987)
* 638cd231fef2a3a5b866cf1d9e07884ead445c07 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754526783
@PatrickRen SGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
}, {
"hash" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12447",
"triggerID" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a31ea3da34b97b40c26325312c20af411adc19b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12447)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 665de48bdcb5dd56e9fc415183f324e5d7a15e38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538)
* 21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r550387001
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
+ boolean overridden = false;
+ String userValue = props.getProperty(key);
+ if (override) {
+ LOG.warn(
+ String.format(
+ "Property %s is provided but will be overridden from %s to %s",
Review comment:
thanks,you are right , Here is redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r563447765
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
props);
}
+ /** setParitionDiscoverySetting . */
Review comment:
@becketqin Thanks for comment,ACK！VisibleForTesting is better ! i will update it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33da876b229f8c2ff4f32b0903cf48c76e1b8c16 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 638cd231fef2a3a5b866cf1d9e07884ead445c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014)
* 18ccb0196ac6025aff2aab2102ee6f0403e0d921 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-771289361
Hi,@becketqin , How does things go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754492541
hi,@becketqin WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r563552260
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
props);
}
+ /** setParitionDiscoverySetting . */
Review comment:
@becketqin, please take a look this updates,thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-760774148
Hi,@becketqin .I have completed the addition of the unit test ,please take a look when you hava spare cycle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987)
* 638cd231fef2a3a5b866cf1d9e07884ead445c07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525)
* 665de48bdcb5dd56e9fc415183f324e5d7a15e38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18ccb0196ac6025aff2aab2102ee6f0403e0d921 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33da876b229f8c2ff4f32b0903cf48c76e1b8c16 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954)
* d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
}, {
"hash" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12447",
"triggerID" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18ccb0196ac6025aff2aab2102ee6f0403e0d921 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111)
* a31ea3da34b97b40c26325312c20af411adc19b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12447)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r563447765
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
props);
}
+ /** setParitionDiscoverySetting . */
Review comment:
@becketqin Thanks for comment,ACK！VisibleForTesting is better ! i will update it
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
props);
}
+ /** setParitionDiscoverySetting . */
Review comment:
@becketqin, please take a look this updates,thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r556309253
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
Review comment:
Hi,@becketqin.Does this unit test only need to check the properties of KafkaSource or partitionDiscoveryIntervalMs of KafkaSourceEnumerator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r550387230
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
Review comment:
i think override is readable. “isBounded” also indicates that the property needs to be overridden
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754492059
hi,@PatrickRen . Do you have a good idea to judge that the stop offset is not specified?.all Stopping offset is initialized as NoStoppingOffsetsInitializer object.there is not feature to distinguish whether it is specified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 638cd231fef2a3a5b866cf1d9e07884ead445c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014)
* 18ccb0196ac6025aff2aab2102ee6f0403e0d921 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644)
* 33da876b229f8c2ff4f32b0903cf48c76e1b8c16 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong removed a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
wuchong removed a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752863052
@PatrickRen will help to review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
}, {
"hash" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12447",
"triggerID" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a31ea3da34b97b40c26325312c20af411adc19b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12447)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752863080
cc @becketqin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r556211376
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
Review comment:
Thanks, @becketqin .okey,I will take your suggestion and add a unit test!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 665de48bdcb5dd56e9fc415183f324e5d7a15e38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538)
* 21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 33da876b229f8c2ff4f32b0903cf48c76e1b8c16 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954)
* d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-763265985
@becketqin,Hi qin ,Is the current PR continuing to review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r558006111
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java
##########
@@ -82,6 +82,57 @@ public void testBasicRead() throws Exception {
executeAndVerify(env, stream);
}
+ @Test
+ public void testParitionDiscoverySetting() throws Exception {
Review comment:
It sounds pretty good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r553402067
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
Review comment:
It looks that we should only disable auto discovery here in the following two cases:
1. The source is bounded.
2. The source has stopping offsets and the user did not explicitly set the discovery interval.
In other cases, we don't need to do anything. So the logic here could just become something like:
```
boolean hasStoppingOffsets = !(stoppingOffsetsInitializer instanceof NoStoppingOffsetsInitializer);
boolean hasParitionDiscoverySetting = props.getProperty(KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS.key()) != null;
if (boundedness == Bounded ||
(hasStoppingOffsets && !hasParititionDiscoverySetting)) {
props.set(KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS.key(-1))
}
```
It seems easier to understand.
BTW, can we also add a unit test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 638cd231fef2a3a5b866cf1d9e07884ead445c07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r550384551
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
Review comment:
override->isBounded maybe more readable
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
+ boolean overridden = false;
+ String userValue = props.getProperty(key);
+ if (override) {
+ LOG.warn(
+ String.format(
+ "Property %s is provided but will be overridden from %s to %s",
Review comment:
L431 has printed the log,here till needed?
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
+ boolean overridden = false;
+ String userValue = props.getProperty(key);
+ if (override) {
+ LOG.warn(
+ String.format(
+ "Property %s is provided but will be overridden from %s to %s",
+ key, userValue, value));
+ props.setProperty(key, value);
+ overridden = true;
+ } else {
+ if (userValue != null) {
+
Review comment:
if statement do nothing looks weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-755126133
hi,@wuchong Do you have time to review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
}, {
"hash" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12014",
"triggerID" : "638cd231fef2a3a5b866cf1d9e07884ead445c07",
"triggerType" : "PUSH"
}, {
"hash" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111",
"triggerID" : "18ccb0196ac6025aff2aab2102ee6f0403e0d921",
"triggerType" : "PUSH"
}, {
"hash" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a31ea3da34b97b40c26325312c20af411adc19b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18ccb0196ac6025aff2aab2102ee6f0403e0d921 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12111)
* a31ea3da34b97b40c26325312c20af411adc19b4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r550387370
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
+ boolean overridden = false;
+ String userValue = props.getProperty(key);
+ if (override) {
+ LOG.warn(
+ String.format(
+ "Property %s is provided but will be overridden from %s to %s",
+ key, userValue, value));
+ props.setProperty(key, value);
+ overridden = true;
+ } else {
+ if (userValue != null) {
+
Review comment:
@zhuxiaoshang .thanks for review. Yes, I should use a more elegant way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752863052
@PatrickRen will help to review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r557809080
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java
##########
@@ -82,6 +82,57 @@ public void testBasicRead() throws Exception {
executeAndVerify(env, stream);
}
+ @Test
+ public void testParitionDiscoverySetting() throws Exception {
Review comment:
It seems better to put this test into a new `KafkaSourceBuilderTest` class and separate it to a few methods testing one case each.
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java
##########
@@ -108,6 +108,15 @@
return new KafkaSourceBuilder<>();
}
+ /**
+ * Returns the props for the Kafka Source.
+ *
+ * @return props for the Kafka Source.
+ */
+ public Properties getProps() {
Review comment:
Should this method be added to `KafkaSourceBuilder` instead of in `KafkaSource`? And this method probably should be package private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-771289361
Hi,@becketqin , How does things go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zck573693104 commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
zck573693104 commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r550393172
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
+ boolean overridden = false;
+ String userValue = props.getProperty(key);
+ if (override) {
+ LOG.warn(
+ String.format(
+ "Property %s is provided but will be overridden from %s to %s",
+ key, userValue, value));
+ props.setProperty(key, value);
+ overridden = true;
+ } else {
+ if (userValue != null) {
+
Review comment:
Imitate another method maybeoverride . set a default value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r558004634
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java
##########
@@ -108,6 +108,15 @@
return new KafkaSourceBuilder<>();
}
+ /**
+ * Returns the props for the Kafka Source.
+ *
+ * @return props for the Kafka Source.
+ */
+ public Properties getProps() {
Review comment:
I think getProps() and getBoundedness() in KafkaSource are similar,we need get props from KafkaSource object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r587193000
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -423,14 +430,15 @@ private void parseAndSetRequiredProperties() {
startingOffsetsInitializer.getAutoOffsetResetStrategy().name().toLowerCase(),
true);
- // If the source is bounded, do not run periodic partition discovery.
- if (maybeOverride(
- KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS.key(),
- "-1",
- boundedness == Boundedness.BOUNDED)) {
- LOG.warn(
- "{} property is overridden to -1 because the source is bounded.",
- KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS);
+ // If the source is bounded or stoppingOffsetsInitializer is specified, do not run periodic
Review comment:
I think these should be exposed to users in the official documents
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-789396324
@becketqin ，Hi qin ,Is the current PR continuing to review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-755945542
Hi, @PatrickRen,@becketqin. Do you have time to review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754512467
@xiaoHoly What about `instanceof NoStoppingOffsetInitializer`?
It is indeed possible that a user provides a custom `OffsetsInitializer` which is semantically equivalent to `NoStoppingOffsetInitializer`, but I think this is a kind of misuse, since the purpose of `setUnbounded` method is to provide a set of offsets so that the stream could stop there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752826517
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93 (Thu Dec 31 03:04:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20777).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
}, {
"hash" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987",
"triggerID" : "d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4e08a53ce0ebe5f58ffda56d2e96fa4e88533af Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754439352
@xiaoHoly Thanks for the pull request~
I took more investigation on the logic here. Actually the partition discovery should be enabled by default when:
1. Source is unbounded
2. **Stopping offset** is not specified.
The scenario is when user invokes `setUnbounded` method of the builder to specify stopping offset for partitions. If the partition discovery is also enabled under this scenario, the source will never switch to finished status even if all splits have reached the stopping offsets, because SplitEnumerator won't signal NoMoreSplitsEvent if partition discovery is enabled.
@xiaoHoly Can you update the code accordingly? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r562412668
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
props);
}
+ /** setParitionDiscoverySetting . */
Review comment:
This method seems quite confusing. I would suggest the following:
1. Make `parseAndSetRequiredProperties()` package private and annotate it as `VisibleForTesting`.
2. Add a package private `getProps()` method to the `KafkaSourceBuilder` and annotate it as `VisibleForTesting`.
The unit test can just use the above two methods without exposing them to the end users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zck573693104 commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
zck573693104 commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r550393596
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -458,6 +458,29 @@ private boolean maybeOverride(String key, String value, boolean override) {
return overridden;
}
+ private boolean maybeOverridePartitionDiscovery(String key, String value, boolean override) {
+ boolean overridden = false;
+ String userValue = props.getProperty(key);
+ if (override) {
+ LOG.warn(
+ String.format(
+ "Property %s is provided but will be overridden from %s to %s",
+ key, userValue, value));
+ props.setProperty(key, value);
+ overridden = true;
+ } else {
+ if (userValue != null) {
+
Review comment:
maybeoverride and your new method.Only the default value is different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525)
* 665de48bdcb5dd56e9fc415183f324e5d7a15e38 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-755131351
Hi @xiaoHoly , I'm not familiar with this part code. I think @PatrickRen and @becketqin will help to review the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754462341
@PatrickRen Thanks reminding, I ignore this, I will update my code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
}, {
"hash" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644",
"triggerID" : "21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5",
"triggerType" : "PUSH"
}, {
"hash" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954",
"triggerID" : "33da876b229f8c2ff4f32b0903cf48c76e1b8c16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21c6c5cfdbaa95cb8d99274f69b9190ca8aec0c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11644)
* 33da876b229f8c2ff4f32b0903cf48c76e1b8c16 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11954)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
}, {
"hash" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538",
"triggerID" : "665de48bdcb5dd56e9fc415183f324e5d7a15e38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 665de48bdcb5dd56e9fc415183f324e5d7a15e38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752828536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525",
"triggerID" : "9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfbf0f8575de20c3c3d672ce1bf64f3c5e2ed93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11525)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-752826319
cc,@wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org