You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Piotr Tarnowski (JIRA)" <ji...@apache.org> on 2009/06/03 11:12:07 UTC
[jira] Created: (JSPWIKI-568) jspwiki.propertyfile cannot be
defined as system property (like cascading properties)
jspwiki.propertyfile cannot be defined as system property (like cascading properties)
-------------------------------------------------------------------------------------
Key: JSPWIKI-568
URL: https://issues.apache.org/jira/browse/JSPWIKI-568
Project: JSPWiki
Issue Type: Improvement
Components: Core & storage
Affects Versions: 2.8.2
Reporter: Piotr Tarnowski
Priority: Trivial
I would like to define where the jspwiki.properties file is located outside of web.xml with system properties, for example in /etc/default/tomcat5.5 as:
JAVA_OPTS=" -Djspwiki.propertyfile=/opt/jspwiki/jspwiki.properties"
having this after deploying new jspwiki.war I neither have to recreate jspwiki.properties nor alter default web.xml
change is in single line:
--- branches/JSPWIKI_2_8_BRANCH/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:49:40.000000000 +0200
+++ JSPWiki-2.8.2/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:38:13.000000000 +0200
@@ -115,7 +115,7 @@
*/
public static Properties loadWebAppProps( ServletContext context )
{
- String propertyFile = context.getInitParameter(PARAM_PROPERTYFILE);
+ String propertyFile = getInitParameter(context, PARAM_PROPERTYFILE);
InputStream propertyStream = null;
try
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-568) jspwiki.propertyfile cannot be
defined as system property (like cascading properties)
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske resolved JSPWIKI-568.
----------------------------------
Resolution: Fixed
Fix Version/s: 3.0
2.8.3
Assignee: Harry Metske
Fixed in 2.8.3-svn-10 and 3.0.0-svn-125
> jspwiki.propertyfile cannot be defined as system property (like cascading properties)
> -------------------------------------------------------------------------------------
>
> Key: JSPWIKI-568
> URL: https://issues.apache.org/jira/browse/JSPWIKI-568
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Affects Versions: 2.8.2
> Reporter: Piotr Tarnowski
> Assignee: Harry Metske
> Priority: Trivial
> Fix For: 2.8.3, 3.0
>
> Attachments: JSPWIKI-568.patch
>
>
> I would like to define where the jspwiki.properties file is located outside of web.xml with system properties, for example in /etc/default/tomcat5.5 as:
> JAVA_OPTS=" -Djspwiki.propertyfile=/opt/jspwiki/jspwiki.properties"
> having this after deploying new jspwiki.war I neither have to recreate jspwiki.properties nor alter default web.xml
> change is in single line:
> --- branches/JSPWIKI_2_8_BRANCH/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:49:40.000000000 +0200
> +++ JSPWiki-2.8.2/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:38:13.000000000 +0200
> @@ -115,7 +115,7 @@
> */
> public static Properties loadWebAppProps( ServletContext context )
> {
> - String propertyFile = context.getInitParameter(PARAM_PROPERTYFILE);
> + String propertyFile = getInitParameter(context, PARAM_PROPERTYFILE);
> InputStream propertyStream = null;
> try
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-568) jspwiki.propertyfile cannot be
defined as system property (like cascading properties)
Posted by "Piotr Tarnowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piotr Tarnowski updated JSPWIKI-568:
------------------------------------
Attachment: JSPWIKI-568.patch
Patch which solves JSPWIKI-568 issue
> jspwiki.propertyfile cannot be defined as system property (like cascading properties)
> -------------------------------------------------------------------------------------
>
> Key: JSPWIKI-568
> URL: https://issues.apache.org/jira/browse/JSPWIKI-568
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Affects Versions: 2.8.2
> Reporter: Piotr Tarnowski
> Priority: Trivial
> Attachments: JSPWIKI-568.patch
>
>
> I would like to define where the jspwiki.properties file is located outside of web.xml with system properties, for example in /etc/default/tomcat5.5 as:
> JAVA_OPTS=" -Djspwiki.propertyfile=/opt/jspwiki/jspwiki.properties"
> having this after deploying new jspwiki.war I neither have to recreate jspwiki.properties nor alter default web.xml
> change is in single line:
> --- branches/JSPWIKI_2_8_BRANCH/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:49:40.000000000 +0200
> +++ JSPWiki-2.8.2/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:38:13.000000000 +0200
> @@ -115,7 +115,7 @@
> */
> public static Properties loadWebAppProps( ServletContext context )
> {
> - String propertyFile = context.getInitParameter(PARAM_PROPERTYFILE);
> + String propertyFile = getInitParameter(context, PARAM_PROPERTYFILE);
> InputStream propertyStream = null;
> try
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-568) jspwiki.propertyfile cannot be
defined as system property (like cascading properties)
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715991#action_12715991 ]
Harry Metske commented on JSPWIKI-568:
--------------------------------------
+1 from me for the idea.
I always like to have environment parameters outside an ear or war file.
> jspwiki.propertyfile cannot be defined as system property (like cascading properties)
> -------------------------------------------------------------------------------------
>
> Key: JSPWIKI-568
> URL: https://issues.apache.org/jira/browse/JSPWIKI-568
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Affects Versions: 2.8.2
> Reporter: Piotr Tarnowski
> Priority: Trivial
> Attachments: JSPWIKI-568.patch
>
>
> I would like to define where the jspwiki.properties file is located outside of web.xml with system properties, for example in /etc/default/tomcat5.5 as:
> JAVA_OPTS=" -Djspwiki.propertyfile=/opt/jspwiki/jspwiki.properties"
> having this after deploying new jspwiki.war I neither have to recreate jspwiki.properties nor alter default web.xml
> change is in single line:
> --- branches/JSPWIKI_2_8_BRANCH/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:49:40.000000000 +0200
> +++ JSPWiki-2.8.2/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:38:13.000000000 +0200
> @@ -115,7 +115,7 @@
> */
> public static Properties loadWebAppProps( ServletContext context )
> {
> - String propertyFile = context.getInitParameter(PARAM_PROPERTYFILE);
> + String propertyFile = getInitParameter(context, PARAM_PROPERTYFILE);
> InputStream propertyStream = null;
> try
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-568) jspwiki.propertyfile cannot be
defined as system property (like cascading properties)
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716889#action_12716889 ]
Janne Jalkanen commented on JSPWIKI-568:
----------------------------------------
+1 as well; though you can already use the servlet context init params from within your container to set the location of jspwiki.properties, but an extra method does not hurt anyone.
> jspwiki.propertyfile cannot be defined as system property (like cascading properties)
> -------------------------------------------------------------------------------------
>
> Key: JSPWIKI-568
> URL: https://issues.apache.org/jira/browse/JSPWIKI-568
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Affects Versions: 2.8.2
> Reporter: Piotr Tarnowski
> Priority: Trivial
> Attachments: JSPWIKI-568.patch
>
>
> I would like to define where the jspwiki.properties file is located outside of web.xml with system properties, for example in /etc/default/tomcat5.5 as:
> JAVA_OPTS=" -Djspwiki.propertyfile=/opt/jspwiki/jspwiki.properties"
> having this after deploying new jspwiki.war I neither have to recreate jspwiki.properties nor alter default web.xml
> change is in single line:
> --- branches/JSPWIKI_2_8_BRANCH/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:49:40.000000000 +0200
> +++ JSPWiki-2.8.2/src/com/ecyrd/jspwiki/PropertyReader.java 2009-06-03 10:38:13.000000000 +0200
> @@ -115,7 +115,7 @@
> */
> public static Properties loadWebAppProps( ServletContext context )
> {
> - String propertyFile = context.getInitParameter(PARAM_PROPERTYFILE);
> + String propertyFile = getInitParameter(context, PARAM_PROPERTYFILE);
> InputStream propertyStream = null;
> try
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.