You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 05:46:13 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #20240: Fix MyPy Errors for Tableau provider

eladkal commented on a change in pull request #20240:
URL: https://github.com/apache/airflow/pull/20240#discussion_r767427089



##########
File path: airflow/providers/tableau/operators/tableau.py
##########
@@ -116,6 +116,8 @@ def execute(self, context: dict) -> str:
 
             response = method(resource_id)
 
+        job_id = ''

Review comment:
       You can just move the assignent of response.id outside of the if.
   There is no need for assigning empty string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org