You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/12 18:36:22 UTC
[GitHub] [airflow] potiuk opened a new pull request #14209: Add better description and guidance in case of sqlite version mismatch
potiuk opened a new pull request #14209:
URL: https://github.com/apache/airflow/pull/14209
Closes: #14208
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#issuecomment-778416628
[The Workflow run](https://github.com/apache/airflow/actions/runs/561950737) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14209:
URL: https://github.com/apache/airflow/pull/14209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#discussion_r575691109
##########
File path: docs/apache-airflow/howto/set-up-database.rst
##########
@@ -59,6 +59,51 @@ the example below.
The exact format description is described in the SQLAlchemy documentation, see `Database Urls <https://docs.sqlalchemy.org/en/14/core/engines.html>`__. We will also show you some examples below.
+SQLite database setup
+---------------------
Review comment:
```suggestion
Setting up a SQLite Database
----------------------------
```
To keep one style of headings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#issuecomment-778375322
Updated @ashb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#discussion_r575649606
##########
File path: docs/apache-airflow/howto/set-up-database.rst
##########
@@ -59,6 +59,45 @@ the example below.
The exact format description is described in the SQLAlchemy documentation, see `Database Urls <https://docs.sqlalchemy.org/en/14/core/engines.html>`__. We will also show you some examples below.
+SQLite database setup
+---------------------
+
+SQLite database can be used to run Airflow for development purpose as it does not require any database server
Review comment:
Can you add docs about connection URI? The sections for other databases cover at least one example of such a URI, so adding an example in this section would be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#discussion_r575659666
##########
File path: docs/apache-airflow/howto/set-up-database.rst
##########
@@ -59,6 +59,45 @@ the example below.
The exact format description is described in the SQLAlchemy documentation, see `Database Urls <https://docs.sqlalchemy.org/en/14/core/engines.html>`__. We will also show you some examples below.
+SQLite database setup
+---------------------
+
+SQLite database can be used to run Airflow for development purpose as it does not require any database server
Review comment:
Good point. Added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#issuecomment-778377103
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#discussion_r575448578
##########
File path: airflow/configuration.py
##########
@@ -243,7 +243,11 @@ def _validate_config_dependencies(self):
# Some of the features in storing rendered fields require sqlite version >= 3.15.0
min_sqlite_version = '3.15.0'
if StrictVersion(sqlite3.sqlite_version) < StrictVersion(min_sqlite_version):
- raise AirflowConfigException(f"error: cannot use sqlite version < {min_sqlite_version}")
+ raise AirflowConfigException(
+ f"error: cannot use sqlite version < {min_sqlite_version}. "
Review comment:
```suggestion
f"error: sqlite C library version too old (< {min_sqlite_version}). "
```
##########
File path: airflow/configuration.py
##########
@@ -243,7 +243,11 @@ def _validate_config_dependencies(self):
# Some of the features in storing rendered fields require sqlite version >= 3.15.0
min_sqlite_version = '3.15.0'
if StrictVersion(sqlite3.sqlite_version) < StrictVersion(min_sqlite_version):
- raise AirflowConfigException(f"error: cannot use sqlite version < {min_sqlite_version}")
+ raise AirflowConfigException(
+ f"error: cannot use sqlite version < {min_sqlite_version}. "
+ f"See https://github.com/apache/airflow/blob/master/docs/apache-airflow/"
+ f"howto/set-up-database.rst#sqlite-database-setup"
Review comment:
```suggestion
f"See {docs_url("howto/set-up-database.rst#sqlite-database-setup")}"
```
(`from airflow.utils.docs import docs_url`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14209: Add better description and guidance in case of sqlite version mismatch
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14209:
URL: https://github.com/apache/airflow/pull/14209#issuecomment-778401382
[The Workflow run](https://github.com/apache/airflow/actions/runs/561950737) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org