[jira] [Commented] (LUCENE-8199) TestBackwardsCompatibility#testAllVersionsTested should fail if the version of a bwc index is missing

["Jim Ferenczi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395179#comment-16395179 ] 

Jim Ferenczi commented on LUCENE-8199:
--------------------------------------

Argh, scratch that, this is only true for bugfix releases. For minor and major releases we have two versions that are not released in the non-release branches so the leniency is needed. There is no way to know if a minor release that is not the latest in the major has been released or not so this leniency is needed. The release howto has been updated with a specific section about adding version for bugfix releases in the non-release branches, I don't have a better solution so I'll close this issue for now.

> TestBackwardsCompatibility#testAllVersionsTested should fail if the version of a bwc index is missing
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8199
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8199
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Jim Ferenczi
>            Priority: Major
>
> There is a leniency in the test that makes the test pass if a bwc index doesn't have a version associated to it:
> {code:java}
> // we could be missing up to 1 file, which may be due to a release that is in progress
>     if (missingFiles.size() <= 1 && extraFiles.isEmpty()) {
>       // success
>       return;
>     }
> {code}
> I think this test can be removed since we add the new released version in the non-release branches only after the release.  Then we'd need to add the released version *and*
>  the BWC test in the non-release branches in the same commit so that the test never fails. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org