You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/04/21 16:14:16 UTC
[GitHub] [superset] villebro commented on a diff in pull request #23772: chore(e2e): skip the worst offender of flaky tests.
villebro commented on code in PR #23772:
URL: https://github.com/apache/superset/pull/23772#discussion_r1173951641
##########
superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts:
##########
@@ -734,7 +734,8 @@ describe('Dashboard edit', () => {
cy.getBySel('dashboard-charts-filter-search-input').clear();
});
- it('should disable the Save button when undoing', () => {
+ // TODO fix this test! This was the #1 flaky test as of 4/21/23 according to cypress dashboard.
+ xit('should disable the Save button when undoing', () => {
Review Comment:
not sure about worst offender; This test was restarted 11 times before I finally caved in and `xit`ed it in #23751 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org