You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2012/03/27 16:00:31 UTC
[jira] [Created] (HBASE-5644) [findbugs] Fix null pointer warnings.
[findbugs] Fix null pointer warnings.
-------------------------------------
Key: HBASE-5644
URL: https://issues.apache.org/jira/browse/HBASE-5644
Project: HBase
Issue Type: Sub-task
Reporter: Jonathan Hsieh
See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5644) [findbugs] Fix null pointer warnings.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5644:
---------------------------------------
Attachment: HBASE-5644.patch
Attached the patch and analysis sheet.
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247898#comment-13247898 ]
Hudson commented on HBASE-5644:
-------------------------------
Integrated in HBase-TRUNK #2717 (See [https://builds.apache.org/job/HBase-TRUNK/2717/])
HBASE-5644 [findbugs] Fix null pointer warnings (Uma Maheswara Rao G) (Revision 1310125)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/trunk/dev-support/findbugs-exclude.xml
* /hbase/trunk/dev-support/test-patch.properties
* /hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaConfigured.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Merge.java
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Fix For: 0.96.0
>
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247318#comment-13247318 ]
Jonathan Hsieh commented on HBASE-5644:
---------------------------------------
Code portion looks good to me.
On the spread sheet, one suggestion:
HTable - row 2, 3
- delete -- why is the type bool? Maybre change to ServerCallable<Void>? (two cases).
Ex:
{code}
@Override
public void delete(final Delete delete)
throws IOException {
new ServerCallable<Void>(connection, tableName, delete.getRow(), operationTimeout) {
public Void call() throws IOException {
server.delete(location.getRegionInfo().getRegionName(), delete);
return null; // FindBugs NP_BOOLEAN_RETURN_NULL
}
}.withRetries();
}
{code}
4,5,6, 7 smells funny but I buy it.
Seems like findbugs doesn't handle ?: very well.
bq. Used, but not extensively ( only in Hadoop). are you suggesting not to use it here?
What I wrote above was unclear. You use Preconditions in some places (Store), and there are places you don't (ShutdownHook). Seems like you could us it in a few more places? Not a big deal, but it makes code easier to read by conveying more intent IMO.
Maybe you chose not to use because it wasn't at the top of a method?
bq. RSStatusTmplImpl is Autogenerated Jamon code. I wanted to fix it but I am not familiar in Jamon code generation area . Let some one or you can update this change if you are familiar. If not, can I file a separate bug?
You can get this one, it is pretty straightforward. The source of the autogen RSStatusTmplImpl data is here. Take a look, just modify there and it will just percolate that code through to the java version.
https://github.com/apache/hbase/blob/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon#L48
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247253#comment-13247253 ]
Uma Maheswara Rao G commented on HBASE-5644:
--------------------------------------------
Thanks a lot Jon for taking a look.
{quote}
Test failure on TestSplitTransactionOnCluster seems to be legit – it hung on my machine locally 2x.
{quote}
Looks TestSplitTransactionOnCluster is failing randomly with out the patch as well. Just filed HBASE-5726.
{quote}
Have you used Preconditions before? It is slightly more compact and seems little better at conveying intent.
{quote}
Used, but not extensively ( only in Hadoop). are you suggesting not to use it here?
{quote}
There was another NP findbugs warnings from build 1365: Mind handling this one too?
Possible null pointer dereference of serverInfo in org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(Writer) on exception path
{quote}
Yes, I added this comment remarks in my analysis sheet.
RSStatusTmplImpl is Autogenerated Jamon code. I wanted to fix it but I am not familiar in Jamon code generation area :(. Let some one or you can update this change if you are familiar. If not, can I file a separate bug?
{code}
HServerInfo serverInfo = null;
ServerName serverName = null;
try {
serverInfo = regionServer.getHServerInfo();
serverName = regionServer.getServerName();
} catch (IOException e) {
e.printStackTrace();
}
{code}
It is ignoring the exception here and proceeding and using serverInfo. This can cause NPE here if getHServerInfo throws IOE.
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247673#comment-13247673 ]
Hadoop QA commented on HBASE-5644:
----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521568/HBASE-5644.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1412//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1412//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1412//console
This message is automatically generated.
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247811#comment-13247811 ]
Jonathan Hsieh commented on HBASE-5644:
---------------------------------------
Oh yeah, it is nice to see hadoop qa not complain when it ran your patch!
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Fix For: 0.96.0
>
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246456#comment-13246456 ]
Uma Maheswara Rao G commented on HBASE-5644:
--------------------------------------------
@Jon, could you please take a look?
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5644) [findbugs] Fix null pointer warnings.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5644:
---------------------------------------
Status: Patch Available (was: Open)
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247997#comment-13247997 ]
Hudson commented on HBASE-5644:
-------------------------------
Integrated in HBase-TRUNK-security #159 (See [https://builds.apache.org/job/HBase-TRUNK-security/159/])
HBASE-5644 [findbugs] Fix null pointer warnings (Uma Maheswara Rao G) (Revision 1310125)
Result = FAILURE
jmhsieh :
Files :
* /hbase/trunk/dev-support/findbugs-exclude.xml
* /hbase/trunk/dev-support/test-patch.properties
* /hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaConfigured.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Merge.java
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Fix For: 0.96.0
>
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5644) [findbugs] Fix null pointer warnings.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5644:
---------------------------------------
Attachment: NullPointerFindBugs_Analysis.xlsx
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247610#comment-13247610 ]
Uma Maheswara Rao G commented on HBASE-5644:
--------------------------------------------
@Jon, Thanks a lot for review!
{quote}
HTable - row 2, 3
* delete – why is the type bool? Maybre change to ServerCallable<Void>? (two cases).
{quote}
yes, this would be correct.done.
{quote}
What I wrote above was unclear. You use Preconditions in some places (Store), and there are places you don't (ShutdownHook). Seems like you could us it in a few more places? Not a big deal, but it makes code easier to read by conveying more intent IMO.
Maybe you chose not to use because it wasn't at the top of a method?
{quote}
seems like findbugs not detecting precondition checks in all the places like inside try, inner-classes.
so, I did not put pre-condions in all the places.
{quote}
You can get this one, it is pretty straightforward. The source of the autogen RSStatusTmplImpl data is here. Take a look, just modify there and it will just percolate that code through to the java version.
{quote}
thanks for the reference. updated with this patch.
thanks
Uma
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244095#comment-13244095 ]
Hadoop QA commented on HBASE-5644:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520867/HBASE-5644.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1365//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1365//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1365//console
This message is automatically generated.
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Uma Maheswara Rao G (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G reassigned HBASE-5644:
------------------------------------------
Assignee: Uma Maheswara Rao G
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5644) [findbugs] Fix null pointer warnings.
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5644:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
@Uma. Nice work. I've committed a slightly modified version of your patch (fixed some spacing nits).
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Fix For: 0.96.0
>
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5644) [findbugs] Fix null pointer
warnings.
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247097#comment-13247097 ]
Jonathan Hsieh commented on HBASE-5644:
---------------------------------------
First quick review (I have more to review, will continue hopefully in next day)
Test failure on TestSplitTransactionOnCluster seems to be legit -- it hung on my machine locally 2x.
Have you used Preconditions before? It is slightly more compact and seems little better at conveying intent.
http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Preconditions.html
There was another NP findbugs warnings from build 1365: Mind handling this one too?
Possible null pointer dereference of serverInfo in org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(Writer) on exception path
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5644) [findbugs] Fix null pointer warnings.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5644:
---------------------------------------
Attachment: HBASE-5644.patch
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira