You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/05 07:50:48 UTC

[GitHub] [hudi] codope opened a new pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

codope opened a new pull request #4512:
URL: https://github.com/apache/hudi/pull/4512


   ## What is the purpose of the pull request
   
   [#3419](https://github.com/apache/hudi/pull/3419) allowed to preserve commit metadata while clustering so as to support incremental queries with replacecommits in timeline. However, it also preserved filenames despite the writes due to clustering going to a new filegroup. This PR fixes that behavior.
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4512:
URL: https://github.com/apache/hudi/pull/4512#issuecomment-1005458302


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4899",
       "triggerID" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 88fed889b20d81fa71c156a7b8e87c2c3651de2f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4899) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4512:
URL: https://github.com/apache/hudi/pull/4512


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4512:
URL: https://github.com/apache/hudi/pull/4512#issuecomment-1005458302


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4899",
       "triggerID" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 88fed889b20d81fa71c156a7b8e87c2c3651de2f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4899) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4512:
URL: https://github.com/apache/hudi/pull/4512#issuecomment-1005490941


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4899",
       "triggerID" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 88fed889b20d81fa71c156a7b8e87c2c3651de2f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4899) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4512:
URL: https://github.com/apache/hudi/pull/4512#issuecomment-1005456587


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 88fed889b20d81fa71c156a7b8e87c2c3651de2f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4512: [HUDI-3170] Do not preserve filename when preserveCommitMetadata enabled

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4512:
URL: https://github.com/apache/hudi/pull/4512#issuecomment-1005456587


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "88fed889b20d81fa71c156a7b8e87c2c3651de2f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 88fed889b20d81fa71c156a7b8e87c2c3651de2f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org