Re: Proposed enhancement to jar plugin.jelly

[Jason van Zyl <ja...@maven.org>]

On Fri, 2004-01-16 at 15:24, Eric Giguere wrote:
> Hi all
> 
> A simple modification proposed for the pluggin.jelly for the jar plugin.
> As it is now, it calls ant:jar but only with the exclusions. Listing 
> exclusions is sometime longer than inclusions. By adding a property in 
> the build.properties (maven.jar.includes) and modifying plugin.jelly 
> like this:
> 
> cvs diff plugin.jelly (in directory 
> F:\java\apache-public-cvs\maven-plugins\jar\)
> Index: plugin.jelly
> ===================================================================
> RCS file: /home/cvspublic/maven-plugins/jar/plugin.jelly,v
> retrieving revision 1.27
> diff -r1.27 plugin.jelly
> 32c32,33
> <       excludes="${maven.jar.excludes}">
> ---
>  >       excludes="${maven.jar.excludes}"
>  >       includes="${maven.jar.includes}">
> 
> allows usage of both includes and excludes which can be very usefull in 
> certain circumptances.

Do you have some examples?

We definitely appreciate the patch but reasons are always helpful :-)

Jira is also a more appropriate place for patches and suggested
enhancements:

http://jira.codehaus.org

> My first enhancement proposal, is it the right place to do it? If not, 
> sorry for the unwanted traffic.
> Didn't call it a patch either, neither did I open a bug for this since 
> its not a bug ;)
> 
> Eric.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
-- 
jvz.

Jason van Zyl
jason@maven.org
http://maven.apache.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.

-- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org

Re: Proposed enhancement to jar plugin.jelly

[Eric Giguere <er...@videotron.ca>]

Hi Jason
Got ya, I'll do that next time (codehaus)
Sure, a couple of reasons: flexibility, ability to use to power of the 
tool shelled by the plugin (Ant jar tag), and in my particular 
situation, write shorter lists of patterns.

This happens mainly in projects that deals with not so well source 
layout scheme, like the one I'm on.
We build jars from a single code base, and at some point, I had an 
exlude list of 8 items, that can be replaced by 1 include. The base dir 
for the jar task holds 9 sub-directories but only one goes in the target 
jar.

Its obvious that such things doesn't happen with well defined project / 
sub project structure or those having one source base, one artifact 
generated, but unfortunetly, we don't always deal with those situations, 
not me in the recent years anyway (corporate world isn't always as clean 
as it shoud...;)). We have one project producing many jars from a single 
source base. In that sense, adding the possibility in the jar plugin 
seems reasonable since it doesn't prevent it from executing in its 
default mode and allowed me to shorten the list.

If I find a way to manipulate some more the <ant:jar> tag using jelly 
(I'm kinda new to this), maybe I'll have some more enhancements to 
propose. After all, the ant:jar tag is way more flexible than what is 
currently exposed with the jar extension. Exposing already existing 
functionnality does seem desirable to me, as long as it doesn't 
compromise the purpose and behavior of the shell itself.

IMHO
Eric.

Jason van Zyl wrote:

>On Fri, 2004-01-16 at 15:24, Eric Giguere wrote:
>  
>
>>Hi all
>>
>>A simple modification proposed for the pluggin.jelly for the jar plugin.
>>As it is now, it calls ant:jar but only with the exclusions. Listing 
>>exclusions is sometime longer than inclusions. By adding a property in 
>>the build.properties (maven.jar.includes) and modifying plugin.jelly 
>>like this:
>>
>>cvs diff plugin.jelly (in directory 
>>F:\java\apache-public-cvs\maven-plugins\jar\)
>>Index: plugin.jelly
>>===================================================================
>>RCS file: /home/cvspublic/maven-plugins/jar/plugin.jelly,v
>>retrieving revision 1.27
>>diff -r1.27 plugin.jelly
>>32c32,33
>><       excludes="${maven.jar.excludes}">
>>---
>> >       excludes="${maven.jar.excludes}"
>> >       includes="${maven.jar.includes}">
>>
>>allows usage of both includes and excludes which can be very usefull in 
>>certain circumptances.
>>    
>>
>
>Do you have some examples?
>
>We definitely appreciate the patch but reasons are always helpful :-)
>
>Jira is also a more appropriate place for patches and suggested
>enhancements:
>
>http://jira.codehaus.org
>
>  
>
>>My first enhancement proposal, is it the right place to do it? If not, 
>>sorry for the unwanted traffic.
>>Didn't call it a patch either, neither did I open a bug for this since 
>>its not a bug ;)
>>
>>Eric.
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
>>For additional commands, e-mail: users-help@maven.apache.org
>>    
>>



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org