You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2017/12/22 10:03:17 UTC
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/1714
[CARBONDATA-1932] Add version for CarbonData
Add version for CarbonData
Are there any other good idea for CarbonData version?
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata addVersion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit b54611addf700b229d358d88c0eada1e302619f2
Author: xubo245 <60...@...>
Date: 2017-12-22T09:59:39Z
[CARBONDATA-1932] Add version for CarbonData
Add version for CarbonData
----
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1070/
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2286/
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158620368
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
I think you can do it as the same as spark, it generates a file called 'spark-version-info.properties' when build, and then read version information from this file at runtime.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1084/
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158573382
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
I also think so, but I don't know how to implement it. I will try.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1714
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2530/
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158714905
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
I think it's a good way to do like spark, it's not complexity , I can help you to implement this.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1714
When we test carbondata performance, we need know spark verison and carbondata version, like in concurrency test case.
Spark have version infomation in code, but carbondata no this. So we need implement the function.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1714
retest this please
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158704044
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
@zzcclp It has a little complexity in spark, is there better solution?
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 closed the pull request at:
https://github.com/apache/carbondata/pull/1714
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1714
@xuchuanyin I have replied above
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
GitHub user xubo245 reopened a pull request:
https://github.com/apache/carbondata/pull/1714
[CARBONDATA-1932] Add version for CarbonData
Add version for CarbonData
Are there any other good idea for CarbonData version?
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata addVersion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 4a70571974bcc1e4b4ea90d1b9c8fd1b945ffa8c
Author: xubo245 <60...@...>
Date: 2017-12-22T09:59:39Z
[CARBONDATA-1932] Add version for CarbonData
Add version for CarbonData
commit dbb3318aabd64f2090243af6fa87f96ce6c8469c
Author: xubo245 <60...@...>
Date: 2017-12-23T01:49:41Z
remove some test case and change the comment
----
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1714
jacky required print spark verison and carbondata version in concurrency test case.
Spark have version infomation in code, but carbondata no this.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1714
I assign the jira to @zzcclp , and close this PR.
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158505304
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
here, it is better to automatically get version number from pom file.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1714
retest this please
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1072/
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158782714
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
@zzcclp I assign the jira to you, and close this PR.
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158701971
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
Ok, I will try. Thank you.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2289/
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1714
@xubo245 why this version info is needed?
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1714
why need to work on this pr ?
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1044/
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 closed the pull request at:
https://github.com/apache/carbondata/pull/1714
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158505347
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/version/VersionTest.scala ---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.spark.testsuite.version
+
+import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.util.CarbonProperties
+import org.apache.spark.sql.{CarbonSession, SparkSession}
+import org.apache.spark.sql.test.util.QueryTest
+import org.scalatest.BeforeAndAfterAll
+
+/**
+ * Created by root on 12/22/17.
--- End diff --
remove this comment.
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158779576
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -1108,6 +1114,11 @@
*/
public static final String CARBON_DATA_FILE_DEFAULT_VERSION = "V3";
+ /**
+ * current CarbonData version
+ */
+ public static final String CARBONDATA_DEFAULT_VERSION = "1.3.0-SNAPSHOT";
--- End diff --
Ok, you can do it.
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2300/
---
[GitHub] carbondata issue #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1714
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2265/
---
[GitHub] carbondata pull request #1714: [CARBONDATA-1932] Add version for CarbonData
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1714#discussion_r158573385
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/version/VersionTest.scala ---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.spark.testsuite.version
+
+import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.util.CarbonProperties
+import org.apache.spark.sql.{CarbonSession, SparkSession}
+import org.apache.spark.sql.test.util.QueryTest
+import org.scalatest.BeforeAndAfterAll
+
+/**
+ * Created by root on 12/22/17.
--- End diff --
ok
---