You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/12/27 11:02:22 UTC
[GitHub] [openwhisk] sciabarracom opened a new pull request #4782: A docker
image for the standalone openwhisk
sciabarracom opened a new pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782
<!--- Provide a concise summary of your changes in the Title -->
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
This PR builds a docker image for standalone supports and adds a few properties to allow to pass the required parameters to run the standalone in a docker image
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
Discussed in ML
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [x] Deployment
- [ ] CLI
- [ ] General tooling
- [x] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [x] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarracom merged pull request #4782: A docker image
for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarracom merged pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365522748
##########
File path: core/standalone/start.sh
##########
@@ -0,0 +1,29 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+docker run --rm -d \
+ -h openwhisk --name openwhisk \
+ -p 3233:3233 -p 3232:3232 \
+ -v //var/run/docker.sock:/var/run/docker.sock \
+ ${1:-openwhisk}/standalone
+sleep 5
Review comment:
you can curl the playground apis and wait for a response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365498537
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM scala
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+ADD init /
+ADD stop /bin/stop
+RUN chmod +x /bin/stop ;\
Review comment:
Just to confirm - For docker-in-docker case is the version of Docker packaged within container needs to be same as one on the host?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] markusthoemmes commented on a change in pull request
#4782: A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
markusthoemmes commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361797883
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
Review comment:
Shouldn‘t this use openjdk like all our other images?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361962494
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
Review comment:
I already did this. Works. Will submit the change with the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/0fcbe814457d593b6350eb1a5559443e1db23dc0?src=pr&el=desc) will **decrease** coverage by `6.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 85.19% 78.53% -6.67%
==========================================
Files 197 197
Lines 8843 8843
Branches 610 610
==========================================
- Hits 7534 6945 -589
- Misses 1309 1898 +589
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.23%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [0fcbe81...e3181f7](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365522827
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
Review comment:
```suggestion
If you have `docker` and `bash` installed, you can launch the standalone OpenWhisk from the Docker image with:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #4782: A docker image for
the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569517783
Note that some aspect like embedded Kafka support may not work as expected due to Docker networking. See #4628 and [kafka listeners explanation][1] for details. Which should be ok though as this mode (`--kafka`) would mostly be used by developers extending OpenWhisk and they would be better of using the java mode
[1]: https://rmoff.net/2018/08/02/kafka-listeners-explained/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io commented on issue #4782: A docker image for
the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8eb922f568d7843cdb1068252d29ba5723b30283?src=pr&el=desc) will **decrease** coverage by `6.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
=========================================
- Coverage 84.89% 78.3% -6.59%
=========================================
Files 198 198
Lines 8836 8836
Branches 602 602
=========================================
- Hits 7501 6919 -582
- Misses 1335 1917 +582
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.61%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [8eb922f...8337973](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk [work in progress - do not
merge yet]
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk [work in progress - do not merge yet]
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361970406
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+RUN yum -y update && yum -y install git tar curl hostname
+RUN curl -sL \
+ https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz \
+ | tar xzvf - -C /usr/bin --strip 1 docker/docker
+RUN curl -sL \
+ https://github.com/apache/openwhisk-cli/releases/download/${WSK_VERSION}/OpenWhisk_CLI-${WSK_VERSION}-linux-amd64.tgz \
+ | tar xzvf - -C /usr/bin wsk
+ADD ${OPENWHISK_JAR} /openwhisk-standalone.jar
+ADD init.sh /
+RUN touch /bin/xdg-open ; chmod +x /init.sh /bin/xdg-open
Review comment:
May be then we add a flag to disable auto browser launch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365522969
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
+
+`bash <(curl -sL https://s.apache.org/openwhisk.sh)`
+
+If you do not want to execute arbitrary code straight from the net, you can look at [this script](start.sh), check it and run it when you feel safe.
+
+The script will start the standalone docker, and will also try to open the playground. It was tested on Linux, OSX and Windows with Git Bash. If a browser does not open with playground, access it with `http://localhost:3232`.
+
+You can then install the [wsk cli](https://github.com/apache/openwhisk-cli/releases) and retrieve the command line to configure `wsk` with:
Review comment:
```suggestion
You can then install the [wsk CLI](https://github.com/apache/openwhisk-cli/releases) and retrieve the command line to configure `wsk` with:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #4782: A docker image for
the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569517843
It seems that in this mode upon starting openwhisk docker `docker stop openwhisk` the launched containers do not get removed. Have not dig further in the root cause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361842254
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
Review comment:
Which one is the recommended one to use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/0fcbe814457d593b6350eb1a5559443e1db23dc0?src=pr&el=desc) will **decrease** coverage by `6.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 85.19% 78.53% -6.67%
==========================================
Files 197 197
Lines 8843 8843
Branches 610 610
==========================================
- Hits 7534 6945 -589
- Misses 1309 1898 +589
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.23%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [0fcbe81...e3181f7](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365523005
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
+
+`bash <(curl -sL https://s.apache.org/openwhisk.sh)`
+
+If you do not want to execute arbitrary code straight from the net, you can look at [this script](start.sh), check it and run it when you feel safe.
+
+The script will start the standalone docker, and will also try to open the playground. It was tested on Linux, OSX and Windows with Git Bash. If a browser does not open with playground, access it with `http://localhost:3232`.
+
+You can then install the [wsk cli](https://github.com/apache/openwhisk-cli/releases) and retrieve the command line to configure `wsk` with:
+
+`docker logs openwhisk | grep 'wsk property'`
+
+To shut down properly openwhisk and the other containers it creates, use [this script](stop.sh) or the command:
Review comment:
```suggestion
To properly shut down OpenWhisk and containers it creates, use [this script](stop.sh) or run the command:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361962761
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+RUN yum -y update && yum -y install git tar curl hostname
+RUN curl -sL \
+ https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz \
+ | tar xzvf - -C /usr/bin --strip 1 docker/docker
+RUN curl -sL \
+ https://github.com/apache/openwhisk-cli/releases/download/${WSK_VERSION}/OpenWhisk_CLI-${WSK_VERSION}-linux-amd64.tgz \
+ | tar xzvf - -C /usr/bin wsk
+ADD ${OPENWHISK_JAR} /openwhisk-standalone.jar
+ADD init.sh /
+RUN touch /bin/xdg-open ; chmod +x /init.sh /bin/xdg-open
Review comment:
This one is to avoid the error message. Browser automation cannot work from the docker container... afaik.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361852070
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+RUN yum -y update && yum -y install git tar curl hostname
+RUN curl -sL \
+ https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz \
+ | tar xzvf - -C /usr/bin --strip 1 docker/docker
+RUN curl -sL \
+ https://github.com/apache/openwhisk-cli/releases/download/${WSK_VERSION}/OpenWhisk_CLI-${WSK_VERSION}-linux-amd64.tgz \
+ | tar xzvf - -C /usr/bin wsk
+ADD ${OPENWHISK_JAR} /openwhisk-standalone.jar
+ADD init.sh /
+RUN touch /bin/xdg-open ; chmod +x /init.sh /bin/xdg-open
Review comment:
For me on Mac automatic browser launch did not work. Probably this would only work on linux. Which should be ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365509364
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM scala
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+ADD init /
+ADD stop /bin/stop
+RUN chmod +x /bin/stop ;\
Review comment:
No. We have this situation for all the openwhisk invokers. They control an external docker that is usually of a different version. I aligned the version of the packaged docker to the same of the invoker image. Strictly speaking is not a "docker-in-docker", is simply the docker client controlling the external docker via a volume mount of the socket. Starting from version 18.x you can use an older docker client to control newer instances (previously you had to specify the API level, no more).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8eb922f568d7843cdb1068252d29ba5723b30283?src=pr&el=desc) will **decrease** coverage by `6.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 84.89% 78.63% -6.26%
==========================================
Files 198 197 -1
Lines 8836 8843 +7
Branches 602 610 +8
==========================================
- Hits 7501 6954 -547
- Misses 1335 1889 +554
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.61%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [8eb922f...0e5e9cb](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361962838
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,25 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+#### Launching OpenWhisk standalone from Docker:
+
+You can launch the standalone openwhisk from the docker image with:
+
+```bash
+docker run --rm -d \
Review comment:
Good idea! Will try to implement it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on issue #4782: A docker image for
the standalone openwhisk [work in progress - do not merge yet]
Posted by GitBox <gi...@apache.org>.
sciabarra commented on issue #4782: A docker image for the standalone openwhisk [work in progress - do not merge yet]
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-572983422
I think it is ready for merging. I added:
- documentation
- a start.sh script that also open the playground
- the start script can be shortened to https://s.apache.org/openwhisk.sh (to do after merging)
- tested the start.sh script in osx, linux, windows
- a stop script that also cleans the other images created
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8eb922f568d7843cdb1068252d29ba5723b30283?src=pr&el=desc) will **decrease** coverage by `6.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 84.89% 78.63% -6.26%
==========================================
Files 198 197 -1
Lines 8836 8843 +7
Branches 602 610 +8
==========================================
- Hits 7501 6954 -547
- Misses 1335 1889 +554
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.61%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [8eb922f...0e5e9cb](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8eb922f568d7843cdb1068252d29ba5723b30283?src=pr&el=desc) will **decrease** coverage by `6.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 84.89% 78.63% -6.26%
==========================================
Files 198 197 -1
Lines 8836 8843 +7
Branches 602 610 +8
==========================================
- Hits 7501 6954 -547
- Misses 1335 1889 +554
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.61%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [8eb922f...0e5e9cb](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365499859
##########
File path: core/standalone/start.sh
##########
@@ -0,0 +1,29 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+docker run --rm -d \
+ -h openwhisk --name openwhisk \
+ -p 3233:3233 -p 3232:3232 \
+ -v //var/run/docker.sock:/var/run/docker.sock \
+ ${1:-openwhisk}/standalone
+sleep 5
Review comment:
May be bump it to say 10. On My Mac it did not came up in 5 sec and saw a blank page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365498537
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM scala
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+ADD init /
+ADD stop /bin/stop
+RUN chmod +x /bin/stop ;\
Review comment:
Just to confirm - For docker-in-docker case is the version of Docker packaged within container need not be same as one on the host?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8eb922f568d7843cdb1068252d29ba5723b30283?src=pr&el=desc) will **decrease** coverage by `6.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 84.89% 78.63% -6.26%
==========================================
Files 198 197 -1
Lines 8836 8843 +7
Branches 602 610 +8
==========================================
- Hits 7501 6954 -547
- Misses 1335 1889 +554
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.61%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [8eb922f...0e5e9cb](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarracom commented on a change in pull request
#4782: A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365928119
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
+
+`bash <(curl -sL https://s.apache.org/openwhisk.sh)`
Review comment:
I need the changes to be committed so I can create the short url - it is an egg-and-chicken problem :) once it is created I can do the short url
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365522790
##########
File path: core/standalone/README.md
##########
@@ -65,6 +65,12 @@ To pass argument to the run command use
$ ./gradlew :core:standalone:bootRun --args='-m runtimes.json'
```
+You can also build a standalone docker image with:
Review comment:
```suggestion
You can also build a standalone Docker image with:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361963022
##########
File path: core/standalone/src/main/scala/org/apache/openwhisk/standalone/StandaloneDockerSupport.scala
##########
@@ -105,29 +105,46 @@ object StandaloneDockerSupport {
prefix + name
}
+ /**
+ * Returns the hostname to access the playground.
+ * It defaults to localhost but it can be overriden
+ * and it is useful when the standalone is run in a container.
+ */
+ def getExternalHostName(): String = {
+ sys.props.get("whisk.standalone.host.external").getOrElse(getLocalHostName())
+ }
+
/**
* Returns the address to be used by code running outside of container to connect to
* server. On non linux setups its 'localhost'. However for Linux setups its the ip used
* by docker for docker0 network to refer to host system
*/
def getLocalHostName(): String = {
- if (SystemUtils.IS_OS_LINUX) hostIpLinux
- else "localhost"
+ sys.props
+ .get("whisk.standalone.host.name")
+ .getOrElse(if (SystemUtils.IS_OS_LINUX) hostIpLinux
+ else "localhost")
}
def getLocalHostIp(): String = {
- if (SystemUtils.IS_OS_MAC || SystemUtils.IS_OS_WINDOWS)
- hostIpNonLinux
- else hostIpLinux
+ sys.props
+ .get("whisk.standalone.host.ip")
Review comment:
No. But I added it for completeness. For example a scenario where you may want this in kubernetes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361852318
##########
File path: core/standalone/src/main/scala/org/apache/openwhisk/standalone/StandaloneDockerSupport.scala
##########
@@ -105,29 +105,46 @@ object StandaloneDockerSupport {
prefix + name
}
+ /**
+ * Returns the hostname to access the playground.
+ * It defaults to localhost but it can be overriden
+ * and it is useful when the standalone is run in a container.
+ */
+ def getExternalHostName(): String = {
+ sys.props.get("whisk.standalone.host.external").getOrElse(getLocalHostName())
+ }
+
/**
* Returns the address to be used by code running outside of container to connect to
* server. On non linux setups its 'localhost'. However for Linux setups its the ip used
* by docker for docker0 network to refer to host system
*/
def getLocalHostName(): String = {
- if (SystemUtils.IS_OS_LINUX) hostIpLinux
- else "localhost"
+ sys.props
+ .get("whisk.standalone.host.name")
+ .getOrElse(if (SystemUtils.IS_OS_LINUX) hostIpLinux
+ else "localhost")
}
def getLocalHostIp(): String = {
- if (SystemUtils.IS_OS_MAC || SystemUtils.IS_OS_WINDOWS)
- hostIpNonLinux
- else hostIpLinux
+ sys.props
+ .get("whisk.standalone.host.ip")
Review comment:
This I think is not being used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365522867
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
+
+`bash <(curl -sL https://s.apache.org/openwhisk.sh)`
Review comment:
I'm getting: No such short-URL; openwhisk.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365509428
##########
File path: core/standalone/start.sh
##########
@@ -0,0 +1,29 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+docker run --rm -d \
+ -h openwhisk --name openwhisk \
+ -p 3233:3233 -p 3232:3232 \
+ -v //var/run/docker.sock:/var/run/docker.sock \
+ ${1:-openwhisk}/standalone
+sleep 5
Review comment:
Yes it takes a bit of time I know. Also some time even if you open the playground it fails running actions. Eveything is fine after a while. It would be useful to have a readyness check somewhere but I dunno how to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361852384
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,25 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+#### Launching OpenWhisk standalone from Docker:
+
+You can launch the standalone openwhisk from the docker image with:
+
+```bash
+docker run --rm -d \
Review comment:
May be drop making it daemon by default as its useful to see logs at launch itself for new users who are not well versed with Docker. Users who know docker cli well can adapt if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361852254
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,25 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+#### Launching OpenWhisk standalone from Docker:
+
+You can launch the standalone openwhisk from the docker image with:
+
+```bash
+docker run --rm -d \
Review comment:
May be we add a simple shell script which wraps this command and people can then simply use `bash <(curl -s https://s.apache.org/openwhisk.sh)` where we can use use a short url for this script via [Apache Url Shortner](https://s.apache.org/)!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
sciabarra edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-572983422
I think it is ready for merging. I added:
- documentation
- a start.sh script that also open the playground
- the start script can be shortened to https://s.apache.org/openwhisk.sh (to do after merging)
- tested the start.sh script in osx, linux, windows
- a stop script that also cleans the other images created
- also CORS support for the playground as I was having problems with CORS running it locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on a change in pull request #4782:
A docker image for the standalone openwhisk [work in progress - do not
merge yet]
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #4782: A docker image for the standalone openwhisk [work in progress - do not merge yet]
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r362501639
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
+ARG OPENWHISK_JAR
+ENV DOCKER_VERSION=18.06.3-ce
+ENV WSK_VERSION=1.0.0
+RUN yum -y update && yum -y install git tar curl hostname
+RUN curl -sL \
+ https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz \
+ | tar xzvf - -C /usr/bin --strip 1 docker/docker
+RUN curl -sL \
+ https://github.com/apache/openwhisk-cli/releases/download/${WSK_VERSION}/OpenWhisk_CLI-${WSK_VERSION}-linux-amd64.tgz \
+ | tar xzvf - -C /usr/bin wsk
+ADD ${OPENWHISK_JAR} /openwhisk-standalone.jar
+ADD init.sh /
+RUN touch /bin/xdg-open ; chmod +x /init.sh /bin/xdg-open
Review comment:
yup probably it is just simpler to add --no-ui then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365498495
##########
File path: core/standalone/start.sh
##########
@@ -0,0 +1,29 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+docker run --rm -d \
+ -h openwhisk --name openwhisk \
+ -p 3233:3233 -p 3232:3232 \
+ -v //var/run/docker.sock:/var/run/docker.sock \
+ ${1:-openwhisk}/standalone
+sleep 5
+case "$(uname)" in
Review comment:
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] codecov-io edited a comment on issue #4782: A docker
image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#issuecomment-569421200
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=h1) Report
> Merging [#4782](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/0fcbe814457d593b6350eb1a5559443e1db23dc0?src=pr&el=desc) will **decrease** coverage by `6.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4782 +/- ##
==========================================
- Coverage 85.19% 78.61% -6.59%
==========================================
Files 197 197
Lines 8843 8843
Branches 610 610
==========================================
- Hits 7534 6952 -582
- Misses 1309 1891 +582
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-96.23%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-93.85%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0% <0%> (-77.78%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-74.08%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `7.69% <0%> (-50%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/openwhisk/pull/4782/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=footer). Last update [0fcbe81...186e5c3](https://codecov.io/gh/apache/openwhisk/pull/4782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r361852007
##########
File path: core/standalone/Dockerfile
##########
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM amazoncorretto:8u232
Review comment:
You can use `FROM scala`. This image is built by `common/scala` module and is used by other docker images like `controller` and `invoker`. Note this is based on debian
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on a change in pull request #4782: A
docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365522949
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
+
+`bash <(curl -sL https://s.apache.org/openwhisk.sh)`
+
+If you do not want to execute arbitrary code straight from the net, you can look at [this script](start.sh), check it and run it when you feel safe.
+
+The script will start the standalone docker, and will also try to open the playground. It was tested on Linux, OSX and Windows with Git Bash. If a browser does not open with playground, access it with `http://localhost:3232`.
Review comment:
```suggestion
The script will start the standalone controller with Docker, and will also try to open the playground. It was tested on Linux, OSX and Windows with Git Bash. If a browser does not open with playground, access it at `http://localhost:3232`.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4782:
A docker image for the standalone openwhisk
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on a change in pull request #4782: A docker image for the standalone openwhisk
URL: https://github.com/apache/openwhisk/pull/4782#discussion_r365657244
##########
File path: core/standalone/README.md
##########
@@ -380,6 +386,24 @@ This shows an output like below indicating that KubernetesContainerFactory based
}
```
+## Launching OpenWhisk standalone with Docker
+
+If you have docker and bash installed, you can launch the standalone openwhisk from the docker image with just:
+
+`bash <(curl -sL https://s.apache.org/openwhisk.sh)`
Review comment:
May be we skip this for now and later once we have a release done we can create a short url then and update the docs after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services