You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/23 16:39:50 UTC
[GitHub] [tomcat] larsgrefer opened a new pull request #282: Improve IDE support for IntelliJ IDEA
larsgrefer opened a new pull request #282:
URL: https://github.com/apache/tomcat/pull/282
This change makes IntelliJ IDEA and other IDE's aware of some of the coding standards of the Tomcat project.
The .editorconfig file (and the rules therein) will be automatically used by the Editors listed here: https://editorconfig.org/#download
The files in the .idea folder are for IntellIJ IDEA only. I deliberately put them directly there (and not in `res/ide-support/idea`) so no manual setup is neccessary for them to take effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618510753
These need to be placed in `res/ide-support/idea` and you probably want to check that the `ide-intellij` Ant target will do the right thing with them and if not, adjust it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on issue #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618526886
@larsgrefer I'd like to quote @markt-asf on point 2 and 3 while we met in person: "I can type `ant ide-...` and I am done.". If you whink that `ant ide-...` is not present enough, let's change this. You might be spoiled just like my importing a Maven project and it simply works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on issue #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618507565
I am against IDE-specific config files, those should be automatically generated. Next one will request, VS Code, Eclipse, NetBeans, YouNameIt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618521303
Some community members (really) dislike having the clutter in the root of the repository. Some IDEs are worse than others for this (IDEA seems to be one of the better ones). There was a shortish debate on this about 10 years ago and we decided that the res-ide-support approach was the compromise we could all live with.
I dislike the clutter but I agree your views on the disadvantages. That is why I have never used them. I view them as reasonable starting points for relatively new Java developers who new to the Tomcat project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] michael-o edited a comment on issue #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618526886
@larsgrefer I'd like to quote @markt-asf on point 2 and 3 when we met in person: "I can type `ant ide-...` and I am done.". If you whink that `ant ide-...` is not present enough, let's change this. You might be spoiled just like my importing a Maven project and it simply works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] larsgrefer commented on issue #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
larsgrefer commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618515960
@michael-o You already have them for IntelliJ IDEA, Eclipse and NetBeans
My idea was not to hide them in `res/ide-support/idea` but to directly put them where they belong.
Putting them in `res/ide-support/idea` has the following disadvantages in my opinion:
1. After adjusting IDE settings (thus changing the files in .idea) one has to remember to update the copies in `res/ide-support/idea`
2. Ever new contributor must know that the ant target `ide-intellij` exists and execute it.
3. Every existing contributor must remember to reexecute the ant target after checking out a revision where the files in `res/ide-support/idea` are different from his(her) local .idea folder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #282: Improve IDE support for IntelliJ IDEA
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618717780
Please skim to IDEA only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org