You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/03 21:37:38 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #1706: CI: Fix check patch to handle renames / deletes
btashton opened a new pull request #1706:
URL: https://github.com/apache/incubator-nuttx/pull/1706
## Summary
Previously `checkpatch.sh` was using `git show` instead of `git diff`. The issue with this is we get a list of all the changes from all the commits, this breaks the CI check because it will look for those files in the final result of the patch (which might include a file that got renamed and then edited). We only want to look a the final changes which is what we get from `diff`.
We also simplify the computing of the commit range.
## Impact
Style checks should be more robust now.
## Testing
Local testing and this should be validated by the CI run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d merged pull request #1706: CI: Fix check patch to handle renames / deletes
Posted by GitBox <gi...@apache.org>.
v01d merged pull request #1706:
URL: https://github.com/apache/incubator-nuttx/pull/1706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org