You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/06 09:16:39 UTC

[GitHub] [tvm] lhutton1 commented on a diff in pull request #11519: [TFLite] Support quantized GREATER op in TFLite frontend

lhutton1 commented on code in PR #11519:
URL: https://github.com/apache/tvm/pull/11519#discussion_r889967832


##########
tests/python/frontend/tflite/test_forward.py:
##########
@@ -2486,9 +2492,9 @@ def test_all_elemwise():
     _test_forward_elemwise_quantized(_test_maximum)
     _test_forward_elemwise(_test_minimum)
     _test_forward_elemwise_quantized(_test_minimum)
-    _test_forward_elemwise(_test_greater)
     _test_forward_elemwise(_test_squared_difference)
     _test_forward_elemwise(_test_greater_equal)
+    _test_forward_elemwise(_test_greater)

Review Comment:
   Do we also need a call to `_test_forward_elemwise_quantized` to test the quantized version of "greater"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org