You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/12 18:43:11 UTC

[GitHub] kristw edited a comment on issue #6079: [refactor] Migrate from Mocha+Chai to Jest

kristw edited a comment on issue #6079: [refactor] Migrate from Mocha+Chai to Jest
URL: https://github.com/apache/incubator-superset/pull/6079#issuecomment-429421588
 
 
   Ah. It seems like you have to deal with Istanbul as well. 
   `npm run cover` fails. That command is still calling mocha under the hood.
   Perhaps time to get rid of `babel-istanbul` (deprecated) and substitute with `babel-plugin-istanbul`
   https://github.com/istanbuljs/babel-plugin-istanbul
   Rooting for you. This PR is gold 🥇 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org