[GitHub] [incubator-pinot] haibow commented on issue #4774: Refactor virtualColumn to extraColumn

[GitBox <gi...@apache.org>]

haibow commented on issue #4774: Refactor virtualColumn to extraColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-550478573
 
 
   > The current definition of virtual column is the column backed by the VirtualColumnProvider class. VirtualColumnProvider can store physical resources/access remote resources if necessary. If this is not changed, I don't think we need to rename the virtual column to extra column. IMO, extra column is not as intuitive as virtual column.
   
   @Jackie-Jiang Another implication about virtual column is that it is not included in the user query result. It "does not exist in the record", so only physical (non-virtual) columns are used in query processing layers (e,g, select * query). I'm changing the class to extraColumnProvider, so in the near future it can also provide default values to the new columns that are added to the consuming segment at query time.
   
   One other option is to keep the name virtual column as is, but drop the semantic that it is always excluded from the query result. Instead, only exclude columns that start with "$", as used in
   https://github.com/apache/incubator-pinot/blob/master/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java#L218-L219
   
   Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org