You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Ryan Blue (JIRA)" <ji...@apache.org> on 2016/01/11 19:27:39 UTC
[jira] [Commented] (AVRO-1725) Enum schema exhibits same
restriction to enum symbols as to names
[ https://issues.apache.org/jira/browse/AVRO-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092431#comment-15092431 ]
Ryan Blue commented on AVRO-1725:
---------------------------------
+1 for that patch, [~martinkl]. Thanks!
> Enum schema exhibits same restriction to enum symbols as to names
> -----------------------------------------------------------------
>
> Key: AVRO-1725
> URL: https://issues.apache.org/jira/browse/AVRO-1725
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.7
> Reporter: Nikita Makeev
> Attachments: AVRO-1725.patch
>
>
> EnumSchema class in org.apache.avro.Schema has the following code:
> for (String symbol : symbols)
> if (ordinals.put(validateName(symbol), i++) != null)
> which validates enum symbols using validateName() which makes impossible to use symbols that are not conforming to standard for real names.
> That prohibits using of symbols like "" (empty string) or anything starting with number which does not seem to be intended.
> I guess this place requires either some another type of validation or no validation at all. Can provide a patch for both cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)