[GitHub] [pulsar] srkukarni commented on a change in pull request #6964: Change the signature of loadFromSecrets to make it more saner

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #6964:
URL: https://github.com/apache/pulsar/pull/6964#discussion_r425911440



##########
File path: pulsar-io/twitter/src/main/java/org/apache/pulsar/io/twitter/TwitterFireHose.java
##########
@@ -72,7 +72,8 @@
 
     @Override
     public void open(Map<String, Object> config, SourceContext sourceContext) throws IOException {
-        TwitterFireHoseConfig hoseConfig = IOConfigUtils.loadWithSecrets(config, TwitterFireHoseConfig.class, sourceContext);
+        TwitterFireHoseConfig hoseConfigWithoutSecrets = TwitterFireHoseConfig.load(config);

Review comment:
       Connectors can construct their config class in any manner they choose to. Mapping from the the Map<String, Object> using object factory is just one way of doing this. The existing method overloads both, when the function name really is about loading the config class with secrets. Hence the change




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org