You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by jaredjstewart <gi...@git.apache.org> on 2016/10/05 20:36:42 UTC
[GitHub] incubator-geode pull request #254: Feature/geode 999
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/incubator-geode/pull/254
Feature/geode 999
Converted from Firefox webdriver to PhantomJS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/incubator-geode feature/GEODE-999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #254
----
commit 2268062ef73c2404158058de64694dce8768b55b
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-10-03T21:15:59Z
GEODE-999: All unignored UITests now pass
commit d61ec128b98644fd8481fc5c04f432749e1112dc
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-10-05T19:09:12Z
GEODE-999: Converted from Firefox driver to PhantomJS driver to run UITests in headless mode
commit 2f9abdfa23f64014a493ce229406f49740015b40
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-10-05T19:51:46Z
GEODE-999: Wired up uiTest to run as part of precheckin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82068710
--- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java ---
@@ -136,6 +146,29 @@
private static final DecimalFormat df2 = new DecimalFormat(PulseConstants.DECIMAL_FORMAT_PATTERN);
+ @Rule
+ public TestRule testWatcher = new TestWatcher() {
+ @Override
+ public void failed(Throwable t, Description test) {
+ takeScreenshot(test.getDisplayName());
+ }
+ };
+
+ @Rule
+ public RetryRule retryRule = new RetryRule(5);
+
+ public void takeScreenshot(String screenshotName) {
--- End diff --
I found screenshots to be helpful when I was debugging the tests that failed from switching to phantomjs. Maybe we could keep this code around but just keep the screenshot testWatcher off by default so that people can turn them on if desired?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #254: Feature/geode 999
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/254
Have we decided whether we want to put uiTest in precheckin or start a new pipeline?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #254: Feature/geode 999
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on the issue:
https://github.com/apache/incubator-geode/pull/254
Precheckin passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82068961
--- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java ---
@@ -136,6 +146,29 @@
private static final DecimalFormat df2 = new DecimalFormat(PulseConstants.DECIMAL_FORMAT_PATTERN);
+ @Rule
+ public TestRule testWatcher = new TestWatcher() {
+ @Override
+ public void failed(Throwable t, Description test) {
+ takeScreenshot(test.getDisplayName());
+ }
+ };
+
+ @Rule
+ public RetryRule retryRule = new RetryRule(5);
+
+ public void takeScreenshot(String screenshotName) {
--- End diff --
Yeah, this sounds better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart closed the pull request at:
https://github.com/apache/incubator-geode/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82065766
--- Diff: geode-pulse/build.gradle ---
@@ -68,6 +68,11 @@ dependencies {
testCompile project(':geode-core')
testCompile files(project(':geode-core').sourceSets.test.output)
+ testCompile(group: 'com.codeborne', name: 'phantomjsdriver', version: '1.2.1') {
--- End diff --
define a phantomjsdriver.versionin dependency-versions.properties and refer that property here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #254: Feature/geode 999
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on the issue:
https://github.com/apache/incubator-geode/pull/254
Precheckin running
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82066044
--- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java ---
@@ -136,6 +146,29 @@
private static final DecimalFormat df2 = new DecimalFormat(PulseConstants.DECIMAL_FORMAT_PATTERN);
+ @Rule
+ public TestRule testWatcher = new TestWatcher() {
+ @Override
+ public void failed(Throwable t, Description test) {
+ takeScreenshot(test.getDisplayName());
+ }
+ };
+
+ @Rule
+ public RetryRule retryRule = new RetryRule(5);
+
+ public void takeScreenshot(String screenshotName) {
--- End diff --
do we need to take screenshots?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82066319
--- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java ---
@@ -166,18 +197,28 @@ public static void setUpServer(String username, String password, String jsonAuth
passwordElement.submit();
Thread.sleep(3000);
- WebElement userNameOnPulsePage = (new WebDriverWait(driver, 10))
- .until(new ExpectedCondition<WebElement>() {
- @Override
- public WebElement apply(WebDriver d) {
- return d.findElement(By.id("userName"));
- }
- });
+ WebElement userNameOnPulsePage = (new WebDriverWait(driver, 10)).until(new ExpectedCondition<WebElement>() {
+ @Override
+ public WebElement apply(WebDriver d) {
+ return d.findElement(By.id("userName"));
+ }
+ });
assertNotNull(userNameOnPulsePage);
driver.navigate().refresh();
Thread.sleep(7000);
}
+ private static void setUpWebDriver() {
+ DesiredCapabilities capabilities = new DesiredCapabilities();
+ capabilities.setJavascriptEnabled(true);
+ capabilities.setCapability("takesScreenshot", true);
--- End diff --
Let's not take the screen shots.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82068289
--- Diff: geode-pulse/build.gradle ---
@@ -68,6 +68,11 @@ dependencies {
testCompile project(':geode-core')
testCompile files(project(':geode-core').sourceSets.test.output)
+ testCompile(group: 'com.codeborne', name: 'phantomjsdriver', version: '1.2.1') {
--- End diff --
Changed and pushed to this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82065904
--- Diff: .gitignore ---
@@ -13,6 +13,8 @@ build/
build-eclipse/
--- End diff --
do we need to checkin this file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #254: Feature/geode 999
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82067720
--- Diff: .gitignore ---
@@ -13,6 +13,8 @@ build/
build-eclipse/
--- End diff --
I added the `screenshots/` directory so that screenshots taken for failing UITests will not accidentally be checked in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---