You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "dsoumis (via GitHub)" <gi...@apache.org> on 2023/02/01 08:49:49 UTC
[GitHub] [tomcat] dsoumis opened a new pull request, #578: Remove redundant modifiers for interface members
dsoumis opened a new pull request, #578:
URL: https://github.com/apache/tomcat/pull/578
I have parsed the whole project and removed redundant modifiers for interface members resulting in vanishing of ~2000 warnings.
Although it's a big commit, I strongly believe that it should be reviewed and if ok, merged, as it provides an overall more consistent project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #578: Remove redundant modifiers for interface members
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #578: Remove redundant modifiers for interface members
URL: https://github.com/apache/tomcat/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #578: Remove redundant modifiers for interface members
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #578:
URL: https://github.com/apache/tomcat/pull/578#issuecomment-1430113794
I've applied this change via a combination of IDE tools and manual review as the CheckStyle test for redundant modifiers covers more than just interface methods.
I was initially in two minds whether to apply this but as I worked through it, I could see the benefits it offers in making the visibility - particularly of constructors - clearer. Prior to this patch, many were marked as public even though there were effectively package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org