[Impala-ASF-CR] IMPALA-12401: Support more info types for HS2 GetInfo() API

["Csaba Ringhofer (Code Review)" <ge...@cloudera.org>]

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23528 )

Change subject: IMPALA-12401: Support more info types for HS2 GetInfo() API
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23528/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23528/6//COMMIT_MSG@19
PS6, Line 19: types
nit: please wrap commit message at 72 chars


http://gerrit.cloudera.org:8080/#/c/23528/6/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/23528/6/be/src/service/impala-hs2-server.cc@597
PS6, Line 597:     case TGetInfoType::CLI_MAX_COLUMN_NAME_LEN:
optional: I would prefer to extract this switch + the ODBC_KEYWORDS constant to another file, e.g. be/src/service/odbc-helper.h + .cc as impala-hs2-server.cc is already large and complex.

This would be also good practice to create new .cc files in Impala.



-- 
To view, visit http://gerrit.cloudera.org:8080/23528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce5f2b9dcc2e4633b4679b002f57b5b4ea3e8bf
Gerrit-Change-Number: 23528
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 20:05:26 +0000
Gerrit-HasComments: Yes