[jira] [Commented] (PIG-5248) Fix TestCombiner#testGroupByLimit after PoS merge

["Adam Szita (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031231#comment-16031231 ] 

Adam Szita commented on PIG-5248:
---------------------------------

[~rohini] can you take a look on this please?

> Fix TestCombiner#testGroupByLimit after PoS merge
> -------------------------------------------------
>
>                 Key: PIG-5248
>                 URL: https://issues.apache.org/jira/browse/PIG-5248
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Adam Szita
>             Fix For: 0.17.0
>
>
> This test started failing on TEZ after we merged PoS. The test checks if there is a "Combiner plan" among the vertices of Tez execution plan.
> The last step of the query is {{pigServer.registerQuery("d = limit c 2 ; ");}} which is decisive in the case of Tez. It looks like if we check the plan for "d" there is no combiner part, but there is one if we check it for "c" - so without applying limit.
> The reason this didn't come out before is because the alias supplied to {{checkCombinerUsed}} method was disregarded and alias "c" was checked always. This was recently fixed with the PoS merge. (See diff of TestCombiner [here|https://github.com/apache/pig/commit/e766b6bf29e610b6312f8447fc008bed6beb4090?diff=split#diff-8bcae39a2bb998cdfeb8c7af960eb196L360] )



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)