You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:32:49 UTC
[GitHub] [incubator-kyuubi] murong00 opened a new pull request #1365: Refine print environment variables to console
murong00 opened a new pull request #1365:
URL: https://github.com/apache/incubator-kyuubi/pull/1365
### _Why are the changes needed?_
Currently, the enviroment variables are printed to console when using `bin/kyuubi status` or `bin/kyuubi stop` like below:
```
$ bin/kyuubi status
Using kyuubi environment file /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/conf/kyuubi-env.sh to initialize...
JAVA_HOME: /usr/jdk1.8.0_172
KYUUBI_HOME: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating
KYUUBI_CONF_DIR: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/conf
KYUUBI_LOG_DIR: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/logs
KYUUBI_PID_DIR: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/pid
KYUUBI_WORK_DIR_ROOT: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/work
SPARK_HOME: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/externals/spark-3.1.2-bin-hadoop3.2
SPARK_CONF_DIR: /data01/apache-kyuubi-1.4.0-SNAPSHOT-bin-incubating/externals/spark-3.1.2-bin-hadoop3.2/conf
HADOOP_CONF_DIR:
Kyuubi is not running
```
In general, these variables are only needed to display when starting a cluster to keep clean style, something like below:
```
$ bin/kyuubi status
Kyuubi is running (pid: 95472)
$ bin/kyuubi stop
Stopping org.apache.kyuubi.server.KyuubiServer
...
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1365: Refine print environment variables to console
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1365:
URL: https://github.com/apache/incubator-kyuubi/pull/1365#issuecomment-966959969
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1365: Refine print environment variables to console
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1365:
URL: https://github.com/apache/incubator-kyuubi/pull/1365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1365: Refine print environment variables to console
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1365:
URL: https://github.com/apache/incubator-kyuubi/pull/1365#discussion_r748067286
##########
File path: bin/kyuubi
##########
@@ -62,7 +62,11 @@ function kyuubi_rotate_log() {
export KYUUBI_HOME="$(cd "$(dirname "$0")"/..; pwd)"
-. "${KYUUBI_HOME}/bin/load-kyuubi-env.sh"
+if [ $1 == "start" ]; then
Review comment:
or `run`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] murong00 commented on a change in pull request #1365: Refine print environment variables to console
Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #1365:
URL: https://github.com/apache/incubator-kyuubi/pull/1365#discussion_r748075783
##########
File path: bin/kyuubi
##########
@@ -62,7 +62,11 @@ function kyuubi_rotate_log() {
export KYUUBI_HOME="$(cd "$(dirname "$0")"/..; pwd)"
-. "${KYUUBI_HOME}/bin/load-kyuubi-env.sh"
+if [ $1 == "start" ]; then
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org