You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2025/02/28 05:51:24 UTC
[PR] fix(com/grid-comp/markdown): pin `remark-gfm` to v3 to allow inline code block by backticks in Markdown [superset]
hainenber opened a new pull request, #32420:
URL: https://github.com/apache/superset/pull/32420
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(com/grid-comp/markdown): pin `remark-gfm` to v3 to allow inline code block by backticks in Markdown
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #32416
According to [this `remark-gfm` issue post](https://github.com/remarkjs/react-markdown/issues/771#issuecomment-1747243713), `react-markdown` v8 (current version in Superset) only plays well with `remark-gfm` v3, hence the downgrade. The other alternative is to upgrade `react-markdown` to v9 but that has breaking change of [React 18 requirement](https://github.com/remarkjs/react-markdown/releases/tag/9.0.0).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before
https://github.com/user-attachments/assets/816a37d0-75ea-442f-9d1a-2c5e6258a98a
After
https://github.com/user-attachments/assets/5d861226-c98f-4687-b9e8-8e90da2a847a
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Go to `Sales dashboard` example dashboard
2. Add and/or modify a word in `Vehicle Sales Dashboard` Markdown section.
3. Receive crash/error
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(com/grid-comp/markdown): pin `remark-gfm` to v3 to allow inline code block by backticks in Markdown [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #32420:
URL: https://github.com/apache/superset/pull/32420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org