You are viewing a plain text version of this content. The canonical link for it is here.

Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/18 12:38:00 UTC

[jira] [Commented] (YARN-11419) Simplify code and improve readability

    [ https://issues.apache.org/jira/browse/YARN-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678217#comment-17678217 ] 

ASF GitHub Bot commented on YARN-11419:
---------------------------------------

smallzhongfeng opened a new pull request, #5309:
URL: https://github.com/apache/hadoop/pull/5309

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   1. Remove `YarnException` and `IOException`, because they are all subclasses of `Throwable`.
   2. Use `try-resource`.
   3. A non-empty string should be on the left side of the `equal`.
   
   ### How was this patch tested?
   Origin uts.
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> Simplify code and improve readability
> -------------------------------------
>
>                 Key: YARN-11419
>                 URL: https://issues.apache.org/jira/browse/YARN-11419
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client
>            Reporter: jingxiong zhong
>            Priority: Minor
>
> Make the code more readable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org