[GitHub] [incubator-superset] altef commented on issue #8644: [SIP-29] Add support for row-level security

[GitBox <gi...@apache.org>]

altef commented on issue #8644: [SIP-29] Add support for row-level security
URL: https://github.com/apache/incubator-superset/issues/8644#issuecomment-559280062
 
 
   I've been looking into this with an eye toward implementing it, using a slightly different approach:
   
   ### Proposed Change
   
   1. **Add a new model** to describe row level security filters, which references a Table and a Role.  So when adding a row level security filter, you specify a particular Role and Table.
   
   2. **Add the filters in to the query** when applicable.  I've modified the [query function](https://github.com/apache/incubator-superset/blob/master/superset/connectors/sqla/models.py#L979) here to add any relevant to the WHERE clause. 
   
   3. **Create a UI for row level security filters.** I haven't started on this yet, in case I'm missing something and this method proves ill-advised.
   
   
   ### New or Changed Public Interfaces
   * New **row level security filters** interface
   
   ### New dependencies
   N/A
   
   ### Migration Plan and Compatibility
   TBD
   
   
   It all seems to be working as expected at this point.  Does anyone foresee any obvious issues with this method?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org