[GitHub] [beam] pabloem commented on a change in pull request #15862: [BEAM-13165] JdbcIO has a single WriteFn underlying all implementations

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15862:
URL: https://github.com/apache/beam/pull/15862#discussion_r742228340



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -2122,4 +1912,242 @@ public void populateDisplayData(DisplayData.Builder builder) {
       config.populateDisplayData(builder);
     }
   }
+
+  /**
+   * {@link DoFn} class to write results data to a JDBC sink. It supports writing rows one by one
+   * (and returning individual results) - or by batch.
+   *
+   * @param <T>
+   * @param <V>
+   */
+  static class WriteFn<T, V> extends DoFn<T, V> {
+
+    @AutoValue
+    public abstract static class WriteFnSpec<T, V> implements Serializable, HasDisplayData {

Review comment:
       I've made all of these not public. Thanks Alexey!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org