[GitHub] [airflow] ephraimbuddy commented on a change in pull request #22082: Add Codespaces support

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #22082:
URL: https://github.com/apache/airflow/pull/22082#discussion_r822085697



##########
File path: CONTRIBUTING.rst
##########
@@ -197,15 +197,24 @@ From the `apache/airflow <https://github.com/apache/airflow>`_ repo,
 Step 2: Configure Your Environment
 ----------------------------------
 
-You can use either a local virtual env or a Docker-based env. The differences
-between the two are explained `here <https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#development-environments>`__.
+You can use use several development environments for Airflow. If you prefer to have development environments

Review comment:
       ```suggestion
   You can use several development environments for Airflow. If you prefer to have development environments
   ```

##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -598,7 +598,7 @@ function build_images::build_prod_images() {
             "--cache-from=${AIRFLOW_PROD_IMAGE}:cache"
         )
     else
-        echo
+        echod

Review comment:
       ```suggestion
           echo
   ```
   Typo?

##########
File path: CONTRIBUTING.rst
##########
@@ -472,25 +481,27 @@ develop Apache Airflow:
 The table below summarizes differences between the two environments:
 
 
-========================= ================================ =====================================
-**Property**              **Local virtualenv**             **Breeze environment**
-========================= ================================ =====================================
-Test coverage             - (-) unit tests only            - (+) integration and unit tests
-------------------------- -------------------------------- -------------------------------------
-Setup                     - (+) automated with breeze cmd  - (+) automated with breeze cmd
-------------------------- -------------------------------- -------------------------------------
-Installation difficulty   - (-) depends on the OS setup    - (+) works whenever Docker works
-------------------------- -------------------------------- -------------------------------------
-Team synchronization      - (-) difficult to achieve       - (+) reproducible within team
-------------------------- -------------------------------- -------------------------------------
-Reproducing CI failures   - (-) not possible in many cases - (+) fully reproducible
-------------------------- -------------------------------- -------------------------------------
-Ability to update         - (-) requires manual updates    - (+) automated update via breeze cmd
-------------------------- -------------------------------- -------------------------------------
-Disk space and CPU usage  - (+) relatively lightweight     - (-) uses GBs of disk and many CPUs
-------------------------- -------------------------------- -------------------------------------
-IDE integration           - (+) straightforward            - (-) via remote debugging only
-========================= ================================ =====================================
+========================= ================================ ===================================== ========================================

Review comment:
       The line at 481 ` two environments:` can be changed to `three environments`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org