[GitHub] abaruni commented on a change in pull request #272: Verify trigger fire by sideeffect.

[GitBox <gi...@apache.org>]

abaruni commented on a change in pull request #272: Verify trigger fire by sideeffect.
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/272#discussion_r198914010
 
 

 ##########
 File path: tests/src/test/scala/system/health/BasicHealthTest.scala
 ##########
 @@ -212,11 +218,10 @@ class BasicHealthTest
         case e: Exception => throw e
       }
 
-      retry({
-        println("Polling for activations")
-        val activations = wsk.activation.pollFor(N = 1, Some(triggerName), retries = maxRetries)
-        assert(activations.nonEmpty)
-      }, N = 3)
+      // Check if the trigger, that should have been created as reaction on the kafka-message, has been created.
+      // The trigger should have been created by the action, that has been triggered by the kafka message.
+      // If we cannot find it, the most probably the action did not run.
 
 Review comment:
   i don't think this is a good idea as this comment would just be cluttering the code documenting our prior experiences instead of explaining the behavior of the code or the logic behind the implementation, etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services