[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936] Store schema in properties for Spark Views

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935010000


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -283,7 +283,22 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
         // columns etc. in table properties, so that we can work around the Hive metastore issue
         // about not case preserving and make Hive serde table and view support mixed-case column
         // names.
-        properties = tableDefinition.properties ++ tableMetaToTableProps(tableDefinition))
+        properties = tableDefinition.properties ++ tableMetaToTableProps(tableDefinition)
+      )
+      try {
+        client.createTable(tableWithDataSourceProps, ignoreIfExists)
+      } catch {
+        case NonFatal(e) =>

Review Comment:
   ```suggestion
           case NonFatal(e) if ...is_view... =>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org