You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/04/20 21:58:31 UTC
Review Request 33371: Expose Stack to Configuration Endpoints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Bugs: AMBARI-10610
https://issues.apache.org/jira/browse/AMBARI-10610
Repository: ambari
Description
-------
Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
Diffs
-----
ambari-project/pom.xml 12ae96c
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
ambari-server/src/main/resources/key_properties.json 3898963
ambari-server/src/main/resources/properties.json 149d8bc
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
Diff: https://reviews.apache.org/r/33371/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 33371: Expose Stack to Configuration Endpoints
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/#review80814
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On April 20, 2015, 7:58 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33371/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 7:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-10610
> https://issues.apache.org/jira/browse/AMBARI-10610
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml 12ae96c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
> ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
> ambari-server/src/main/resources/key_properties.json 3898963
> ambari-server/src/main/resources/properties.json 149d8bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
>
> Diff: https://reviews.apache.org/r/33371/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 33371: Expose Stack to Configuration Endpoints
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On April 20, 2015, 4:03 p.m., Nate Cole wrote:
> > ambari-project/pom.xml, lines 457-458
> > <https://reviews.apache.org/r/33371/diff/1/?file=936831#file936831line457>
> >
> > Changes here will most assuredly break b.a.o with that one dumb LDAP test.
Bah-hahahaha ... got included by accident in my dev env. I'll remove this change.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/#review80807
-----------------------------------------------------------
On April 20, 2015, 3:58 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33371/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 3:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-10610
> https://issues.apache.org/jira/browse/AMBARI-10610
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml 12ae96c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
> ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
> ambari-server/src/main/resources/key_properties.json 3898963
> ambari-server/src/main/resources/properties.json 149d8bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
>
> Diff: https://reviews.apache.org/r/33371/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 33371: Expose Stack to Configuration Endpoints
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/#review80807
-----------------------------------------------------------
Ship it!
ambari-project/pom.xml
<https://reviews.apache.org/r/33371/#comment130918>
Changes here will most assuredly break b.a.o with that one dumb LDAP test.
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/33371/#comment130919>
Geez, at what point do we just pass in the config object. (Nothing to do here, just complaining)
- Nate Cole
On April 20, 2015, 3:58 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33371/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 3:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-10610
> https://issues.apache.org/jira/browse/AMBARI-10610
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
>
>
> Diffs
> -----
>
> ambari-project/pom.xml 12ae96c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
> ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
> ambari-server/src/main/resources/key_properties.json 3898963
> ambari-server/src/main/resources/properties.json 149d8bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
>
> Diff: https://reviews.apache.org/r/33371/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 33371: Expose Stack to Configuration Endpoints
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/#review80824
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 20, 2015, 5:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33371/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 5:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-10610
> https://issues.apache.org/jira/browse/AMBARI-10610
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
> ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
> ambari-server/src/main/resources/key_properties.json 3898963
> ambari-server/src/main/resources/properties.json 149d8bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java bf82a85
>
> Diff: https://reviews.apache.org/r/33371/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 33371: Expose Stack to Configuration Endpoints
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/#review80828
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 20, 2015, 9:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33371/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 9:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
>
>
> Bugs: AMBARI-10610
> https://issues.apache.org/jira/browse/AMBARI-10610
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
> ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
> ambari-server/src/main/resources/key_properties.json 3898963
> ambari-server/src/main/resources/properties.json 149d8bc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java bf82a85
>
> Diff: https://reviews.apache.org/r/33371/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 33371: Expose Stack to Configuration Endpoints
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33371/
-----------------------------------------------------------
(Updated April 20, 2015, 5:13 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
Changes
-------
New diff to cover the comments.
Bugs: AMBARI-10610
https://issues.apache.org/jira/browse/AMBARI-10610
Repository: ambari
Description
-------
Expose the associated stack of cluster configurations and service version configurations via the REST endpoints. Also include a pre-calculated field for every service configuration version that determines if that particular service configuration version is compatible with the current cluster stack.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 614134e
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java dd5c667
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java 7aea65e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 20f15c0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java 98d1a46
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java f055375
ambari-server/src/main/java/org/apache/ambari/server/state/Config.java bdfe1bd
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 5176d69
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0d9c36a
ambari-server/src/main/resources/key_properties.json 3898963
ambari-server/src/main/resources/properties.json 149d8bc
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 4cdf9cb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 122b9a9
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java bf82a85
Diff: https://reviews.apache.org/r/33371/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley