You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/01/30 12:07:15 UTC

Review Request 30449: LENS-248: lens driver hive and jdbc checkstyle fixes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30449/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-248
    https://issues.apache.org/jira/browse/LENS-248


Repository: lens


Description
-------

removed hive driver checkstyle errors. some jdbc remaining


Diffs
-----

  checkstyle/src/main/resources/checkstyle.xml e519a60fca323cfaaeec6a675969a7f490330778 
  lens-driver-hive/pom.xml 17d411885d38887dbf93027099d11dc83619b21c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 634ec5676173a003917c8dfbcd31717ef04beb43 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 64bc2816122bc2b3dc48a4dd5865ce25b34e4f72 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 97e9fca08cfd9126dfd47f13312953a55f7f8a04 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 9db4538d26fa46fbf63445a91b7c62adee7032d2 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java 4bda55d95df9407ff130fcc4cc4c36946c702021 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveResultSetMetadata.java eb42f3a8470e434ed6932452b7ae0815c2ad85d2 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 6cf5950564d1fe3f0ee72523255f1b1e9c657927 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 282c6c1e5e15a3bc968092db0c8ceb32bbc6b54a 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java 91e67df12e1c8e89fa5ab6efdc7373e2c63e2f71 
  lens-driver-hive/src/main/resources/hivedriver-default.xml 11e7210df90ab34d5e5d2bc19793b22cf35a50f5 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java c63a2565a82b1f594c9a9031aea07c06acf8440d 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 26202d7e99309b8626c7be843f230a044b54aa16 
  lens-driver-hive/src/test/resources/hive-site.xml 116bf1155934e14bfadb8f44ff3a653f555e1304 
  lens-driver-hive/src/test/resources/hivedriver-site.xml 30e64b17c4f72027a37f9dc5149b0073bdf1c0d7 
  lens-driver-hive/testng.xml b98d25284a7ddf110f6b01fdbc218da5bbc55f35 
  lens-driver-hive/testutils/hadoop c1658c71da1b90b6be10427761117abd6fe31977 
  lens-driver-jdbc/pom.xml 0f2230937d306dd8700d31eca8aaa9e1300d5683 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 5b7f5193506ab7436a1a59bb6ea2c693fc1c366f 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ConnectionProvider.java d27af8d6e1516c1c779a6f92c0a0e1f1b577951b 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 555a4953f1273fa7e84e7bc196cc87daf86151bd 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 1b4982a74cc0876b291b06ae008861a91e02fbb1 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5c4970e1805a8ca4ffbbbd2402e3ff6a366656cf 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 590620ff7aa7698249b55c9645565941cf045e93 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 4eacb833909390130115ba6ad7cf7e41e1b8e08b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 5af6ead64132e4587bf1b63ac737068952b16fe6 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java 56d33cb7e718ffe1981f1d8c77f03b1aecf25341 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 7534d89173b2b32ec22bdf14a9c201023ee599b9 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e1988d45cd01f752ce1767c4fc7325e3bb5dfe36 
  lens-driver-jdbc/src/test/resources/hive-site.xml 634c89f87f94f3fe96d2e14f7cfc1f0223a2376c 

Diff: https://reviews.apache.org/r/30449/diff/


Testing
-------

[INFO] Starting audit...
/Users/rajat.khandelwal/Git/grill/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java:22: Wrong order for 'org.apache.lens.driver.jdbc.JDBCDriverConfConstants.*' import.
/Users/rajat.khandelwal/Git/grill/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:38: Wrong order for 'org.apache.lens.server.api.driver.*' import.
Audit done.


Thanks,

Rajat Khandelwal

Re: Review Request 30449: LENS-248: lens driver hive and jdbc checkstyle fixes

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30449/#review70501
-----------------------------------------------------------

Ship it!


Can you update description? It says somethings are still remaining.

- Amareshwari Sriramadasu


On Jan. 30, 2015, 3:02 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30449/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 3:02 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-248
>     https://issues.apache.org/jira/browse/LENS-248
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> removed hive driver checkstyle errors. some jdbc remaining
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/pom.xml 19cdb75812edae0f141fbe05541a59fe319f67b0 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 634ec5676173a003917c8dfbcd31717ef04beb43 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 300cda1d40363e0ab487dc0207531a1b799cb18b 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 97e9fca08cfd9126dfd47f13312953a55f7f8a04 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java 9db4538d26fa46fbf63445a91b7c62adee7032d2 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java 4bda55d95df9407ff130fcc4cc4c36946c702021 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveResultSetMetadata.java eb42f3a8470e434ed6932452b7ae0815c2ad85d2 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 6cf5950564d1fe3f0ee72523255f1b1e9c657927 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 282c6c1e5e15a3bc968092db0c8ceb32bbc6b54a 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java 91e67df12e1c8e89fa5ab6efdc7373e2c63e2f71 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 11e7210df90ab34d5e5d2bc19793b22cf35a50f5 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cc2fe0d2e005a2fa077b8936ac2e13e370cf4c2e 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 2fe7a0686fc29f7c74d7b5702fd793af019c5085 
>   lens-driver-hive/src/test/resources/hive-site.xml 116bf1155934e14bfadb8f44ff3a653f555e1304 
>   lens-driver-hive/src/test/resources/hivedriver-site.xml 30e64b17c4f72027a37f9dc5149b0073bdf1c0d7 
>   lens-driver-hive/testng.xml b98d25284a7ddf110f6b01fdbc218da5bbc55f35 
>   lens-driver-hive/testutils/hadoop c1658c71da1b90b6be10427761117abd6fe31977 
>   lens-driver-jdbc/pom.xml 360f694c9901ee83b9e7a9bfb20ed7995d87a484 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 5b7f5193506ab7436a1a59bb6ea2c693fc1c366f 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ConnectionProvider.java d27af8d6e1516c1c779a6f92c0a0e1f1b577951b 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 555a4953f1273fa7e84e7bc196cc87daf86151bd 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 0e5e27d1e9b3240a96ed460fe659acfebf271a54 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5c4970e1805a8ca4ffbbbd2402e3ff6a366656cf 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 590620ff7aa7698249b55c9645565941cf045e93 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 4eacb833909390130115ba6ad7cf7e41e1b8e08b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 5af6ead64132e4587bf1b63ac737068952b16fe6 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java 56d33cb7e718ffe1981f1d8c77f03b1aecf25341 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 5ecfee456ac5fd929c3de74d1ecc12826cb5766b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 885daad49258eea05827ba62ecdf14db417c6512 
>   lens-driver-jdbc/src/test/resources/hive-site.xml 634c89f87f94f3fe96d2e14f7cfc1f0223a2376c 
>   lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0e81abb6f326e54ab301b779ef65a39c7b329441 
> 
> Diff: https://reviews.apache.org/r/30449/diff/
> 
> 
> Testing
> -------
> 
> ```
> [INFO] Starting audit...
> 
> /Users/rajat.khandelwal/Git/grill/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java:22: Wrong order for 'org.apache.lens.driver.jdbc.JDBCDriverConfConstants.*' import.
> 
> /Users/rajat.khandelwal/Git/grill/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:38: Wrong order for 'org.apache.lens.server.api.driver.*' import.
> 
> Audit done.
> ```
> 
> 
> So basically the rules force something unintuitive:
> 
> unintuitive import order: 
> ```
> import org.apache.lens.server.api.driver.*;
> import org.apache.lens.server.api.driver.DriverQueryStatus.DriverQueryState;
> ```
> 
> Ordered Separated blocks between static imports too. 
> ```
> import static org.apache.lens.driver.jdbc.JDBCDriverConfConstants.*;
> 
> import static org.apache.hadoop.hive.ql.parse.HiveParser.TOK_TMP_FILE;
> ```
> 
> we are using Maven checkstyle plugin 2.9.1 which uses checkstyle 5.7. checkstyle 6.2 has been released and can support better rules. But a newer version of maven checkstyle plugin(which uses 6.2) has not been released yet and is in active development. https://jira.codehaus.org/browse/MCHECKSTYLE-272 So for now we can either make do with a few unintuitive import rules or we can be satisfied with minimum checkstyle violations with no enforcement. 
> 
> 
> Current status:
> ```
> [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ lens-driver-hive ---
> [INFO] Starting audit...
> Audit done.
> .
> .
> .
> [INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ lens-driver-jdbc ---
> [INFO] Starting audit...
> Audit done.
> ```
> 
> Build succeeding. 
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.239s]
> [INFO] Lens .............................................. SUCCESS [1.848s]
> [INFO] Lens API .......................................... SUCCESS [4.685s]
> [INFO] Lens API for server and extensions ................ SUCCESS [4.974s]
> [INFO] Lens Cube ......................................... SUCCESS [6:54.077s]
> [INFO] Lens DB storage ................................... SUCCESS [9.154s]
> [INFO] Lens Query Library ................................ SUCCESS [5.302s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:44.032s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [2.921s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.176s]
> [INFO] Lens Server ....................................... SUCCESS [4:18.795s]
> [INFO] Lens client ....................................... SUCCESS [19.699s]
> [INFO] Lens CLI .......................................... SUCCESS [1:35.831s]
> [INFO] Lens Examples ..................................... SUCCESS [0.950s]
> [INFO] Lens Distribution ................................. SUCCESS [3.995s]
> [INFO] Lens Client Distribution .......................... SUCCESS [5.802s]
> [INFO] Lens ML Lib ....................................... SUCCESS [40.916s]
> [INFO] Lens Regression ................................... SUCCESS [0.433s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:40.790s
> [INFO] Finished at: Fri Jan 30 13:40:15 UTC 2015
> [INFO] Final Memory: 101M/1102M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>