You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/19 08:07:04 UTC

[PR] Enhance MCP protocol contracts and E2E quality gates [shardingsphere]

terrymanu opened a new pull request, #39183:
URL: https://github.com/apache/shardingsphere/pull/39183

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Enhance MCP protocol contracts and E2E quality gates [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39183:
URL: https://github.com/apache/shardingsphere/pull/39183#issuecomment-5015315000

   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: No code-level blocker was found within the MCP/MCP-E2E scope of this Code Correctness Review. This result applies to code scope only; CI was not reviewed by request.
   
   ### Evidence
   
   - Metadata pagination is consistently implemented across request parameters, deterministic ordering, paged results, `has_more`, `next_offset`, `total_match_count`, and the output descriptor: [SearchMetadataToolService.java](mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/metadata/SearchMetadataToolService.java:79), [SearchMetadataPayloadBuilder.java](mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/metadata/SearchMetadataPayloadBuilder.java:54), [mcp-descriptor-core.yaml](mcp/core/src/main/resources/META-INF/shardingsphere-mcp/mcp-descriptors/mcp-descriptor-core.yaml:950).
   - Shadow workflow validation now reports expected and actual values for each field while preserving clear success and failure paths: [ShadowWorkflowValidationService.java](mcp/features/shadow/src/main/java/org/apache/shardingsphere/mcp/feature/shadow/tool/service/ShadowWorkflowValidationService.java:149).
   - The MCP Builder evaluation is restricted to read-only tools and preserves runtime tool discovery, tool-call traces, and evidence artifacts: [AutonomousMCPBuilderEvaluationRunner.java](test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/llm/conversation/AutonomousMCPBuilderEvaluationRunner.java:44).
   - MCP architecture boundaries, protocol descriptions, pagination contracts, workflow lifecycle checks, and secure artifact validation all have corresponding verification paths.
   - Five formatting-only or non-behavioral changes outside MCP were excluded from substantive review.
   
   ### Review Details
   
   - Review Focus: Code Correctness Review
   - Reviewed Scope: PR head `6c3fba16d4012f14fe7d473310fa91a4c6569851`, base `5f8d1c00c6a3e7015d295493a2134da937ad2f54`; the GitHub file list contained 55 files and matched the local triple-dot scope. The review focused on `mcp/**`, `test/e2e/mcp/**`, MCP workflows, descriptors, and documentation.
   - Not Reviewed Scope: CI, check-runs, GitHub Actions logs, formatting-only or non-behavioral changes outside MCP, HTTP authentication, and rate limiting.
   - Verification: Completed full file coverage, production-path tracing, protocol and architecture boundary checks, and a final adversarial review pass. Maven and E2E tests were not rerun. CI not reviewed by request.
   - Release Note / User Docs: MCP protocol version, fixed SDK boundary, pagination behavior, and E2E execution guidance are documented. No additional release note is required for this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Enhance MCP protocol contracts and E2E quality gates [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39183:
URL: https://github.com/apache/shardingsphere/pull/39183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org