You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Wan Kun (Jira)" <ji...@apache.org> on 2023/03/17 02:54:00 UTC
[jira] [Updated] (SPARK-42831) Show result expressions in AggregateExec
[ https://issues.apache.org/jira/browse/SPARK-42831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wan Kun updated SPARK-42831:
----------------------------
Description:
If the result expressions in AggregateExec is non-empty, we should show them. Or we will be confused due to some important expressions did not showed in DAG.
For example, the plan of query SELECT sum(p) from values(cast(23.4 as decimal(7,2))) t(p) was not correct because the result expression MakeDecimal(sum(UnscaledValue(p#0))#1L,17,2) AS sum(p)#2 was now showing
Before
{code:java}
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- HashAggregate(keys=[], functions=[sum(UnscaledValue(p#0))], output=[sum(p)#2])
+- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=11]
+- HashAggregate(keys=[], functions=[partial_sum(UnscaledValue(p#0))], output=[sum#5L])
+- LocalTableScan [p#0]
{code}
After
{code:java}
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- HashAggregate(keys=[], functions=[sum(UnscaledValue(p#0))], results=[MakeDecimal(sum(UnscaledValue(p#0))#1L,17,2) AS sum(p)#2], output=[sum(p)#2])
+- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=38]
+- HashAggregate(keys=[], functions=[partial_sum(UnscaledValue(p#0))], results=[sum#13L], output=[sum#13L])
+- LocalTableScan [p#0]
{code}
was:
If the result expressions in AggregateExec is non-empty, we should show them. Or we will be confused due to some important expressions did not showed in DAG.
For example, the plan of query SELECT sum(p) from values(cast(23.4 as decimal(7,2))) t(p) was not correct because the result expression MakeDecimal(sum(UnscaledValue(p#0))#1L,17,2) AS sum(p)#2 was now showing
> Show result expressions in AggregateExec
> ----------------------------------------
>
> Key: SPARK-42831
> URL: https://issues.apache.org/jira/browse/SPARK-42831
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 3.4.0
> Reporter: Wan Kun
> Priority: Minor
>
> If the result expressions in AggregateExec is non-empty, we should show them. Or we will be confused due to some important expressions did not showed in DAG.
> For example, the plan of query SELECT sum(p) from values(cast(23.4 as decimal(7,2))) t(p) was not correct because the result expression MakeDecimal(sum(UnscaledValue(p#0))#1L,17,2) AS sum(p)#2 was now showing
> Before
> {code:java}
> == Physical Plan ==
> AdaptiveSparkPlan isFinalPlan=false
> +- HashAggregate(keys=[], functions=[sum(UnscaledValue(p#0))], output=[sum(p)#2])
> +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=11]
> +- HashAggregate(keys=[], functions=[partial_sum(UnscaledValue(p#0))], output=[sum#5L])
> +- LocalTableScan [p#0]
> {code}
> After
> {code:java}
> == Physical Plan ==
> AdaptiveSparkPlan isFinalPlan=false
> +- HashAggregate(keys=[], functions=[sum(UnscaledValue(p#0))], results=[MakeDecimal(sum(UnscaledValue(p#0))#1L,17,2) AS sum(p)#2], output=[sum(p)#2])
> +- Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=38]
> +- HashAggregate(keys=[], functions=[partial_sum(UnscaledValue(p#0))], results=[sum#13L], output=[sum#13L])
> +- LocalTableScan [p#0]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org